From e96f0ea3700cfb6c275ff776566c10b315946cb2 Mon Sep 17 00:00:00 2001 From: Johannes Rieken Date: Tue, 9 Mar 2021 15:44:54 +0100 Subject: [PATCH 1/2] todo-tag --- src/vs/vscode.proposed.d.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/vs/vscode.proposed.d.ts b/src/vs/vscode.proposed.d.ts index ad83374f0e1..b3af770f100 100644 --- a/src/vs/vscode.proposed.d.ts +++ b/src/vs/vscode.proposed.d.ts @@ -1558,6 +1558,7 @@ declare module 'vscode' { } // todo@API use openNotebookDOCUMENT to align with openCustomDocument etc? + // todo@API rename to NotebookDocumentContentProvider export interface NotebookContentProvider { readonly options?: NotebookDocumentContentOptions; From aaf6287ecccebda0eba6f78c86670aeb3d8dfe22 Mon Sep 17 00:00:00 2001 From: Johannes Rieken Date: Tue, 9 Mar 2021 15:47:55 +0100 Subject: [PATCH 2/2] remove skipped test --- .../src/singlefolder-tests/notebook.test.ts | 23 ------------------- 1 file changed, 23 deletions(-) diff --git a/extensions/vscode-api-tests/src/singlefolder-tests/notebook.test.ts b/extensions/vscode-api-tests/src/singlefolder-tests/notebook.test.ts index 06458587116..53044d0d280 100644 --- a/extensions/vscode-api-tests/src/singlefolder-tests/notebook.test.ts +++ b/extensions/vscode-api-tests/src/singlefolder-tests/notebook.test.ts @@ -421,29 +421,6 @@ suite('Notebook API tests', function () { await saveFileAndCloseAll(resource); }); - test.skip('change cell language', async function () { - const resource = await createRandomFile('', undefined, '.vsctestnb'); - await vscode.commands.executeCommand('vscode.openWith', resource, 'notebookCoreTest'); - - assert.strictEqual(vscode.window.activeNotebookEditor?.document.cells[0].language, 'typescript'); - assert.strictEqual(vscode.window.activeNotebookEditor?.document.cells[0].cellKind, vscode.NotebookCellKind.Code); - await withEvent(vscode.notebook.onDidChangeCellLanguage, async event => { - await vscode.commands.executeCommand('notebook.cell.changeLanguage', { start: 0, end: 1 }, 'javascript'); - await event; - assert.strictEqual(vscode.window.activeNotebookEditor?.document.cells[0].language, 'javascript'); - }); - - // switch to markdown will change the cell kind - await withEvent(vscode.notebook.onDidChangeNotebookCells, async event => { - await vscode.commands.executeCommand('notebook.cell.changeLanguage', { start: 0, end: 1 }, 'markdown'); - await event; - assert.strictEqual(vscode.window.activeNotebookEditor?.document.cells[0].language, 'markdown'); - assert.strictEqual(vscode.window.activeNotebookEditor?.document.cells[0].cellKind, vscode.NotebookCellKind.Markdown); - }); - - await saveAllFilesAndCloseAll(resource); - }); - test('edit API (replaceMetadata)', async function () { const resource = await createRandomFile('', undefined, '.vsctestnb'); await vscode.commands.executeCommand('vscode.openWith', resource, 'notebookCoreTest');