maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Always require data for EventEmitter.fire

Browse source 
Fixes #93875

The data field should not be optional as this breaks strict null typings. With `EventEmitter<void>`, you can still call `.fire()` with no arguments
This commit is contained in:
Matt Bierner 2020-04-08 14:53:08 -07:00
parent 3bec9a342e
commit 1ed9dcda26
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/vs/vscode.d.ts vendored
View file

@ -1490,7 +1490,7 @@ declare module 'vscode' {
*
* @param data The event object.
*/
fire(data?: T): void;
fire(data: T): void;
/**
* Dispose this object and free resources.