maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fix missing cell execution icon

Browse source
This commit is contained in:
Rob Lourens 2021-04-26 21:35:56 -07:00
parent d89a35b91f
commit 201063aa2e
2 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/vs/workbench/contrib/notebook/browser/contrib/statusBar/executionStatusBarItemController.ts
View file

@ -7,12 +7,11 @@ import { RunOnceScheduler } from 'vs/base/common/async';
import { Event } from 'vs/base/common/event';
import { Disposable, dispose, IDisposable } from 'vs/base/common/lifecycle';
import { localize } from 'vs/nls';
import { themeColorFromId, ThemeIcon } from 'vs/platform/theme/common/themeService';
import { themeColorFromId } from 'vs/platform/theme/common/themeService';
import { ICellVisibilityChangeEvent, NotebookVisibleCellObserver } from 'vs/workbench/contrib/notebook/browser/contrib/statusBar/notebookVisibleCellObserver';
import { ICellViewModel, INotebookEditor, INotebookEditorContribution } from 'vs/workbench/contrib/notebook/browser/notebookBrowser';
import { registerNotebookContribution } from 'vs/workbench/contrib/notebook/browser/notebookEditorExtensions';
import { cellStatusIconError, cellStatusIconSuccess } from 'vs/workbench/contrib/notebook/browser/notebookEditorWidget';
import { executingStateIcon, pendingStateIcon } from 'vs/workbench/contrib/notebook/browser/notebookIcons';
import { NotebookViewModel } from 'vs/workbench/contrib/notebook/browser/viewModel/notebookViewModel';
import { CellStatusbarAlignment, INotebookCellStatusBarItem, NotebookCellExecutionState } from 'vs/workbench/contrib/notebook/common/notebookCommon';
@ -138,14 +137,14 @@ class ExecutionStateCellStatusBarHelper extends Disposable {
};
} else if (runState === NotebookCellExecutionState.Pending) {
return <INotebookCellStatusBarItem>{
icon: pendingStateIcon,
text: '$(notebook-state-pending)',
tooltip: localize('notebook.cell.status.pending', "Pending"),
alignment: CellStatusbarAlignment.Left,
priority: Number.MAX_SAFE_INTEGER
};
} else if (runState === NotebookCellExecutionState.Executing) {
return <INotebookCellStatusBarItem>{
icon: ThemeIcon.modify(executingStateIcon, 'spin'),
text: '$(notebook-state-executing~spin)',
tooltip: localize('notebook.cell.status.executing', "Executing"),
alignment: CellStatusbarAlignment.Left,
priority: Number.MAX_SAFE_INTEGER

2
src/vs/workbench/contrib/notebook/common/notebookCommon.ts
View file

@ -810,7 +810,7 @@ export interface INotebookDiffResult {
export interface INotebookCellStatusBarItem {
readonly alignment: CellStatusbarAlignment;
readonly priority?: number;
readonly text?: string;
readonly text: string;
readonly color?: string | ThemeColor;
readonly backgroundColor?: string | ThemeColor;
readonly tooltip?: string;