maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Merge pull request #110961 from a5hk/snake

Browse source 
camelCase/PascalCase to snake_case
This commit is contained in:
Alexandru Dima 2020-12-18 17:58:57 +01:00 committed by GitHub
parent d5bed1d4a7 db27c55205
commit 202a8fa3eb
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 109 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

44
src/vs/editor/contrib/linesOperations/linesOperations.ts
View file

@ -939,43 +939,39 @@ export class TransposeAction extends EditorAction {
export abstract class AbstractCaseAction extends EditorAction {
public run(_accessor: ServicesAccessor, editor: ICodeEditor): void {
let selections = editor.getSelections();
const selections = editor.getSelections();
if (selections === null) {
return;
}
let model = editor.getModel();
const model = editor.getModel();
if (model === null) {
return;
}
let wordSeparators = editor.getOption(EditorOption.wordSeparators);
const wordSeparators = editor.getOption(EditorOption.wordSeparators);
const textEdits: IIdentifiedSingleEditOperation[] = [];
let commands: ICommand[] = [];
for (let i = 0, len = selections.length; i < len; i++) {
let selection = selections[i];
for (const selection of selections) {
if (selection.isEmpty()) {
let cursor = selection.getStartPosition();
const cursor = selection.getStartPosition();
const word = editor.getConfiguredWordAtPosition(cursor);
if (!word) {
continue;
}
let wordRange = new Range(cursor.lineNumber, word.startColumn, cursor.lineNumber, word.endColumn);
let text = model.getValueInRange(wordRange);
commands.push(new ReplaceCommandThatPreservesSelection(wordRange, this._modifyText(text, wordSeparators),
new Selection(cursor.lineNumber, cursor.column, cursor.lineNumber, cursor.column)));
const wordRange = new Range(cursor.lineNumber, word.startColumn, cursor.lineNumber, word.endColumn);
const text = model.getValueInRange(wordRange);
textEdits.push(EditOperation.replace(wordRange, this._modifyText(text, wordSeparators)));
} else {
let text = model.getValueInRange(selection);
commands.push(new ReplaceCommandThatPreservesSelection(selection, this._modifyText(text, wordSeparators), selection));
const text = model.getValueInRange(selection);
textEdits.push(EditOperation.replace(selection, this._modifyText(text, wordSeparators)));
}
}
editor.pushUndoStop();
editor.executeCommands(this.id, commands);
editor.executeEdits(this.id, textEdits);
editor.pushUndoStop();
}
@ -1049,6 +1045,21 @@ export class TitleCaseAction extends AbstractCaseAction {
}
}
export class SnakeCaseAction extends AbstractCaseAction {
constructor() {
super({
id: 'editor.action.transformToSnakecase',
label: nls.localize('editor.transformToSnakecase', "Transform to Snake Case"),
alias: 'Transform to Snake Case',
precondition: EditorContextKeys.writable
});
}
protected _modifyText(text: string, wordSeparators: string): string {
return text.replace(/(?<=\p{Ll})(\p{Lu})|(?<!\b|_)(\p{Lu})(?=\p{Ll})/gmu, '_$&').toLocaleLowerCase();
}
}
registerEditorAction(CopyLinesUpAction);
registerEditorAction(CopyLinesDownAction);
registerEditorAction(DuplicateSelectionAction);
@ -1069,3 +1080,4 @@ registerEditorAction(TransposeAction);
registerEditorAction(UpperCaseAction);
registerEditorAction(LowerCaseAction);
registerEditorAction(TitleCaseAction);
registerEditorAction(SnakeCaseAction);

83
src/vs/editor/contrib/linesOperations/test/linesOperations.test.ts
View file

@ -8,7 +8,7 @@ import { Position } from 'vs/editor/common/core/position';
import { Selection } from 'vs/editor/common/core/selection';
import { Handler } from 'vs/editor/common/editorCommon';
import { ITextModel } from 'vs/editor/common/model';
import { TitleCaseAction, DeleteAllLeftAction, DeleteAllRightAction, IndentLinesAction, InsertLineAfterAction, InsertLineBeforeAction, JoinLinesAction, LowerCaseAction, SortLinesAscendingAction, SortLinesDescendingAction, TransposeAction, UpperCaseAction, DeleteLinesAction } from 'vs/editor/contrib/linesOperations/linesOperations';
import { TitleCaseAction, DeleteAllLeftAction, DeleteAllRightAction, IndentLinesAction, InsertLineAfterAction, InsertLineBeforeAction, JoinLinesAction, LowerCaseAction, SortLinesAscendingAction, SortLinesDescendingAction, TransposeAction, UpperCaseAction, DeleteLinesAction, SnakeCaseAction } from 'vs/editor/contrib/linesOperations/linesOperations';
import { withTestCodeEditor } from 'vs/editor/test/browser/testCodeEditor';
import { createTextModel } from 'vs/editor/test/common/editorTestUtils';
import type { ICodeEditor } from 'vs/editor/browser/editorBrowser';
@ -534,12 +534,28 @@ suite('Editor Contrib - Line Operations', () => {
withTestCodeEditor(
[
'hello world',
'öçşğü'
'öçşğü',
'parseHTMLString',
'getElementById',
'insertHTML',
'PascalCase',
'CSSSelectorsList',
'iD',
'tEST',
'öçşÖÇŞğüĞÜ',
'audioConverter.convertM4AToMP3();',
'snake_case',
'Capital_Snake_Case',
`function helloWorld() {
return someGlobalObject.printHelloWorld("en", "utf-8");
}
helloWorld();`.replace(/^\s+/gm, '')
], {}, (editor) => {
let model = editor.getModel()!;
let uppercaseAction = new UpperCaseAction();
let lowercaseAction = new LowerCaseAction();
let titlecaseAction = new TitleCaseAction();
let snakecaseAction = new SnakeCaseAction();
editor.setSelection(new Selection(1, 1, 1, 12));
executeAction(uppercaseAction, editor);
@ -580,6 +596,69 @@ suite('Editor Contrib - Line Operations', () => {
executeAction(titlecaseAction, editor);
assert.equal(model.getLineContent(2), 'Öçşğü');
assertSelection(editor, new Selection(2, 1, 2, 6));
editor.setSelection(new Selection(3, 1, 3, 16));
executeAction(snakecaseAction, editor);
assert.equal(model.getLineContent(3), 'parse_html_string');
assertSelection(editor, new Selection(3, 1, 3, 18));
editor.setSelection(new Selection(4, 1, 4, 15));
executeAction(snakecaseAction, editor);
assert.equal(model.getLineContent(4), 'get_element_by_id');
assertSelection(editor, new Selection(4, 1, 4, 18));
editor.setSelection(new Selection(5, 1, 5, 11));
executeAction(snakecaseAction, editor);
assert.equal(model.getLineContent(5), 'insert_html');
assertSelection(editor, new Selection(5, 1, 5, 12));
editor.setSelection(new Selection(6, 1, 6, 11));
executeAction(snakecaseAction, editor);
assert.equal(model.getLineContent(6), 'pascal_case');
assertSelection(editor, new Selection(6, 1, 6, 12));
editor.setSelection(new Selection(7, 1, 7, 17));
executeAction(snakecaseAction, editor);
assert.equal(model.getLineContent(7), 'css_selectors_list');
assertSelection(editor, new Selection(7, 1, 7, 19));
editor.setSelection(new Selection(8, 1, 8, 3));
executeAction(snakecaseAction, editor);
assert.equal(model.getLineContent(8), 'i_d');
assertSelection(editor, new Selection(8, 1, 8, 4));
editor.setSelection(new Selection(9, 1, 9, 5));
executeAction(snakecaseAction, editor);
assert.equal(model.getLineContent(9), 't_est');
assertSelection(editor, new Selection(9, 1, 9, 6));
editor.setSelection(new Selection(10, 1, 10, 11));
executeAction(snakecaseAction, editor);
assert.equal(model.getLineContent(10), 'öçş_öç_şğü_ğü');
assertSelection(editor, new Selection(10, 1, 10, 14));
editor.setSelection(new Selection(11, 1, 11, 34));
executeAction(snakecaseAction, editor);
assert.equal(model.getLineContent(11), 'audio_converter.convert_m4a_to_mp3();');
assertSelection(editor, new Selection(11, 1, 11, 38));
editor.setSelection(new Selection(12, 1, 12, 11));
executeAction(snakecaseAction, editor);
assert.equal(model.getLineContent(12), 'snake_case');
assertSelection(editor, new Selection(12, 1, 12, 11));
editor.setSelection(new Selection(13, 1, 13, 19));
executeAction(snakecaseAction, editor);
assert.equal(model.getLineContent(13), 'capital_snake_case');
assertSelection(editor, new Selection(13, 1, 13, 19));
editor.setSelection(new Selection(14, 1, 17, 14));
executeAction(snakecaseAction, editor);
assert.equal(model.getValueInRange(new Selection(14, 1, 17, 15)), `function hello_world() {
return some_global_object.print_hello_world("en", "utf-8");
}
hello_world();`.replace(/^\s+/gm, ''));
assertSelection(editor, new Selection(14, 1, 17, 15));
}
);