maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Tag issues generated by issue reporter, telemetry improvements

Browse source
This commit is contained in:
Rachel Macfarlane 2018-02-15 12:00:32 -08:00
parent d019a5bed2
commit 2a445d90d2
4 changed files with 16 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
src/vs/code/electron-browser/issue/issueReporterMain.ts
View file

@ -67,6 +67,7 @@ export class IssueReporter extends Disposable {
private logService: ILogService;
private issueReporterModel: IssueReporterModel;
private shouldQueueSearch = true;
private numberOfSearchResultsDisplayed = 0;
private features: IssueReporterFeatures;
private receivedSystemInfo = false;
private receivedPerformanceInfo = false;
@ -444,6 +445,7 @@ export class IssueReporter extends Disposable {
private clearSearchResults(): void {
const similarIssues = document.getElementById('similar-issues');
similarIssues.innerHTML = '';
this.numberOfSearchResultsDisplayed = 0;
}
@debounce(300)
@ -520,8 +522,8 @@ export class IssueReporter extends Disposable {
const issuesText = $('div.list-title');
issuesText.textContent = localize('similarIssues', "Similar issues");
const numResultsToDisplay = results.length < 5 ? results.length : 5;
for (let i = 0; i < numResultsToDisplay; i++) {
this.numberOfSearchResultsDisplayed = results.length < 5 ? results.length : 5;
for (let i = 0; i < this.numberOfSearchResultsDisplayed; i++) {
const issue = results[i];
const link = issue.state ? $('a.issue-link', { href: issue.html_url }) : $('a', { href: issue.html_url });
link.textContent = issue.title;
@ -676,14 +678,13 @@ export class IssueReporter extends Disposable {
return false;
}
if (this.telemetryService) {
/* __GDPR__
"issueReporterSubmit" : {
"issueType" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
}
*/
this.telemetryService.publicLog('issueReporterSubmit', { issueType: this.issueReporterModel.getData().issueType });
}
/* __GDPR__
"issueReporterSubmit" : {
"issueType" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
"numSimilarIssuesDisplayed" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
}
*/
this.telemetryService.publicLog('issueReporterSubmit', { issueType: this.issueReporterModel.getData().issueType, numSimilarIssuesDisplayed: this.numberOfSearchResultsDisplayed });
const issueTitle = encodeURIComponent((<HTMLInputElement>document.getElementById('issue-title')).value);
const queryStringPrefix = product.reportIssueUrl.indexOf('?') === -1 ? '?' : '&';

3
src/vs/code/electron-browser/issue/issueReporterModel.ts
View file

@ -73,7 +73,8 @@ ${this._data.issueDescription}
VS Code version: ${this._data.versionInfo && this._data.versionInfo.vscodeVersion}
OS version: ${this._data.versionInfo && this._data.versionInfo.os}
${this.getInfos()}`;
${this.getInfos()}
<!-- generated by issue reporter -->`;
}
private getIssueTypeTitle(): string {

3
src/vs/code/electron-browser/issue/test/testReporterModel.test.ts
View file

@ -39,6 +39,7 @@ undefined
VS Code version: undefined
OS version: undefined
`);
<!-- generated by issue reporter -->`);
});
});

2
src/vs/platform/issue/electron-main/issueService.ts
View file

@ -47,7 +47,7 @@ export class IssueService implements IIssueService {
});
ipcMain.on('workbenchCommand', (event, arg) => {
this._parentWindow.webContents.send('vscode:runAction', { id: arg });
this._parentWindow.webContents.send('vscode:runAction', { id: arg, from: 'issueReporter' });
});
this._parentWindow = BrowserWindow.getFocusedWindow();