From 2b75c3d5ac346411233565881a696155257c51c7 Mon Sep 17 00:00:00 2001 From: BTNDev <52890714+BTNDev@users.noreply.github.com> Date: Sat, 21 Nov 2020 00:37:46 +0100 Subject: [PATCH] updated javascript for in snippet (#111062) Updated javascript for in snippet to use Object.hasOwnProperty insted of object.hasOwnProperty because of this vulnerability: https://eslint.org/docs/rules/no-prototype-builtins --- extensions/javascript/snippets/javascript.code-snippets | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/extensions/javascript/snippets/javascript.code-snippets b/extensions/javascript/snippets/javascript.code-snippets index b005c80c844..a48a64c2813 100644 --- a/extensions/javascript/snippets/javascript.code-snippets +++ b/extensions/javascript/snippets/javascript.code-snippets @@ -35,7 +35,7 @@ "prefix": "forin", "body": [ "for (const ${1:key} in ${2:object}) {", - "\tif (${2:object}.hasOwnProperty(${1:key})) {", + "\tif (Object.hasOwnProperty.call(${2:object}, ${1:key})) {", "\t\tconst ${3:element} = ${2:object}[${1:key}];", "\t\t$0", "\t}",