Remove empty logging from telemetry2 searches.

This commit is contained in:
Jackson Kearl 2020-01-27 15:44:15 -08:00
parent 4eab357eb8
commit 2ce17a576c
3 changed files with 4 additions and 5 deletions

View file

@ -1,7 +1,6 @@
# Query: \\w+\\?\\..+![(.[]
# Flags: RegExp
# ContextLines: 2
src/vs/base/browser/ui/tree/asyncDataTree.ts:
270 } : undefined,
271 isChecked: options.ariaProvider!.isChecked ? (e) => {

View file

@ -46,7 +46,7 @@ export const openNewSearchEditor =
}
}
telemetryService.publicLog2<{}, {}>('searchEditor/openNewSearchEditor');
telemetryService.publicLog2('searchEditor/openNewSearchEditor');
const input = instantiationService.invokeFunction(getOrMakeSearchEditorInput, { config: { query: selected } });
await editorService.openEditor(input, { pinned: true });
@ -65,7 +65,7 @@ export const createEditorFromSearchResult =
const labelService = accessor.get(ILabelService);
telemetryService.publicLog2<{}, {}>('searchEditor/createEditorFromSearchResult');
telemetryService.publicLog2('searchEditor/createEditorFromSearchResult');
const labelFormatter = (uri: URI): string => labelService.getUriLabel(uri, { relative: true });

View file

@ -118,7 +118,7 @@ export class SearchEditorInput extends EditorInput {
async saveAs(group: GroupIdentifier, options?: ITextFileSaveOptions): Promise<IEditorInput | undefined> {
const path = await this.fileDialogService.pickFileToSave(await this.suggestFileName(), options?.availableFileSystems);
if (path) {
this.telemetryService.publicLog2<{}, {}>('searchEditor/saveSearchResults');
this.telemetryService.publicLog2('searchEditor/saveSearchResults');
if (await this.textFileService.saveAs(this.resource, path, options)) {
this.setDirty(false);
if (!isEqual(path, this.resource)) {
@ -266,7 +266,7 @@ export class SearchEditorContribution implements IWorkbenchContribution {
return undefined;
}
this.telemetryService.publicLog2<{}, {}>('searchEditor/openSavedSearchEditor');
this.telemetryService.publicLog2('searchEditor/openSavedSearchEditor');
const input = instantiationService.invokeFunction(getOrMakeSearchEditorInput, { uri: resource });
const opened = editorService.openEditor(input, { ...options, pinned: resource.scheme === searchEditorScheme, ignoreOverrides: true }, group);
return { override: Promise.resolve(opened) };