maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Change location of Show More Walkthroughs link

Browse source 
Closes #128860
This commit is contained in:
Jackson Kearl 2021-07-17 20:34:11 -07:00
parent f491d5ce97
commit 2cfd397312
No known key found for this signature in database
GPG key ID: DA09A59C409FC400
2 changed files with 25 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/vs/workbench/contrib/welcome/gettingStarted/browser/gettingStarted.css
View file

@ -126,6 +126,14 @@
display: none;
}
.monaco-workbench .part.editor>.content .gettingStartedContainer .gettingStartedSlideCategories li.showWalkthroughsEntry {
display: none;
}
.monaco-workbench .part.editor>.content .gettingStartedContainer.noWalkthroughs .gettingStartedSlideCategories li.showWalkthroughsEntry {
display: unset;
}
.monaco-workbench .part.editor>.content .gettingStartedContainer .gettingStartedSlideCategories>.gettingStartedCategoriesContainer>* {
overflow: hidden;
text-overflow: ellipsis;

23
src/vs/workbench/contrib/welcome/gettingStarted/browser/gettingStarted.ts
View file

@ -62,6 +62,7 @@ import { IEditorOptions } from 'vs/platform/editor/common/editor';
import { coalesce, flatten } from 'vs/base/common/arrays';
import { ThemeSettings } from 'vs/workbench/services/themes/common/workbenchThemeService';
import { ACTIVITY_BAR_BADGE_BACKGROUND, ACTIVITY_BAR_BADGE_FOREGROUND } from 'vs/workbench/common/theme';
import { Codicon } from 'vs/base/common/codicons';
const SLIDE_TRANSITION_TIME_MS = 250;
const configurationKey = 'workbench.startupEditor';
@ -850,20 +851,19 @@ export class GettingStartedPage extends EditorPane {
const recentList = this.buildRecentlyOpenedList();
const gettingStartedList = this.buildGettingStartedWalkthroughsList();
const footer = $('.footer');
const footer = $('.footer', $('p.showOnStartup', {}, showOnStartupCheckbox, $('label.caption', { for: 'showOnStartup' }, localize('welcomePage.showOnStartup', "Show welcome page on startup"))));
const layoutLists = () => {
if (gettingStartedList.itemCount) {
this.container.classList.remove('noWalkthroughs');
reset(leftColumn, startList.getDomElement(), recentList.getDomElement());
reset(rightColumn, gettingStartedList.getDomElement());
reset(footer, $('p.showOnStartup', {}, showOnStartupCheckbox, $('label.caption', { for: 'showOnStartup' }, localize('welcomePage.showOnStartup', "Show welcome page on startup"))));
recentList.setLimit(5);
}
else {
this.container.classList.add('noWalkthroughs');
reset(leftColumn, startList.getDomElement());
reset(rightColumn, recentList.getDomElement());
reset(footer, $('p.showOnStartup', {}, showOnStartupCheckbox, $('label.caption', { for: 'showOnStartup' }, localize('welcomePage.showOnStartup', "Show welcome page on startup"))),
$('p.openAWalkthrough', {}, $('button.button-link', { 'x-dispatch': 'seeAllWalkthroughs' }, localize('openAWalkthrough', "Open Walkthrough..."))));
recentList.setLimit(10);
}
setTimeout(() => this.categoriesPageScrollbar?.scanDomNode(), 50);
@ -997,16 +997,27 @@ export class GettingStartedPage extends EditorPane {
if (this.startList) { this.startList.dispose(); }
// Handle this a bit specially because it's the only item that hides/shows based on live context...
const showWalkthroughsEntry = $('li.showWalkthroughsEntry',
{},
$('button.button-link',
{},
this.iconWidgetFor({ icon: { type: 'icon', icon: Codicon.checklist } }),
$('span', {}, localize('showAllWalkthroughs', "Open a Walkthrough..."))));
const startList = this.startList = new GettingStartedIndexList(
localize('start', "Start"),
'start-container',
10,
undefined,
undefined,
undefined,
showWalkthroughsEntry,
renderStartEntry,
);
startList.register(addDisposableListener(showWalkthroughsEntry, 'click', () => this.commandService.executeCommand('welcome.showAllWalkthroughs')));
startList.setEntries(this.gettingStartedCategories);
startList.onDidChange(() => this.registerDispatchListeners());
return startList;
@ -1143,7 +1154,7 @@ export class GettingStartedPage extends EditorPane {
});
}
private iconWidgetFor(category: IGettingStartedCategory) {
private iconWidgetFor(category: IGettingStartedCategory | { icon: { type: 'icon', icon: ThemeIcon } }) {
const widget = category.icon.type === 'icon' ? $(ThemeIcon.asCSSSelector(category.icon.icon)) : $('img.category-icon', { src: category.icon.path });
widget.classList.add('icon-widget');
return widget;