maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Only dispose TerminalInstance.onExit when it's already disposed

Browse source 
Fixes #130277
This commit is contained in:
Daniel Imms 2021-08-11 05:47:47 -07:00
parent 227601428b
commit 2e23a7c3ad
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/vs/workbench/contrib/terminal/browser/terminalInstance.ts
View file

@ -1332,8 +1332,13 @@ export class TerminalInstance extends Disposable implements ITerminalInstance {
}
}
// First onExit to consumers, this can happen after the terminal has already been disposed.
this._onExit.fire(this._exitCode);
this._onExit.dispose();
// Dispose of the onExit event if the terminal will not be reused again
if (this._isDisposed) {
this._onExit.dispose();
}
}
/**