maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

fixes #104059 (#104193)

Browse source 
Co-authored-by: Andrew Maust <69081050+Andrew884@users.noreply.github.com>
This commit is contained in:
Andrew Maust 2020-08-10 23:46:14 -04:00 committed by GitHub
parent 7e4fd71ad8
commit 2f61d0037c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
extensions/typescript-language-features/src/languageFeatures/completions.ts
View file

@ -641,7 +641,11 @@ class TypeScriptCompletionItemProvider implements vscode.CompletionItemProvider<
const { snippet, parameterCount } = snippetForFunctionCall(item, detail.displayParts);
item.insertText = snippet;
if (parameterCount > 0) {
commands.push({ title: 'triggerParameterHints', command: 'editor.action.triggerParameterHints' });
//Fix for https://github.com/microsoft/vscode/issues/104059
//Don't show parameter hints if "editor.parameterHints.enabled": false
if (vscode.workspace.getConfiguration('editor.parameterHints').get('enabled')) {
commands.push({ title: 'triggerParameterHints', command: 'editor.action.triggerParameterHints' });
}
}
}
}