maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fix potential race in showing/hiding markdown cells

Browse source 
For #126056

We should update the visibility before async rendering
This commit is contained in:
Matt Bierner 2021-06-11 15:03:06 -07:00
parent e54a29d55c
commit 3086bb5956
No known key found for this signature in database
GPG key ID: 099C331567E11888
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/vs/workbench/contrib/notebook/browser/view/renderers/webviewPreloads.ts
View file

@ -921,7 +921,7 @@ async function webviewPreloads(style: PreloadStyles, options: PreloadOptions, re
private readonly _markupCells = new Map<string, MarkupCell>();
private readonly _outputCells = new Map<string, OutputCell>();
private async createMarkupCell(init: webviewMessages.IMarkupCellInitialization, top: number): Promise<MarkupCell> {
private async createMarkupCell(init: webviewMessages.IMarkupCellInitialization, top: number, visible: boolean): Promise<MarkupCell> {
const existing = this._markupCells.get(init.cellId);
if (existing) {
console.error(`Trying to create markup that already exists: ${init.cellId}`);
@ -929,6 +929,7 @@ async function webviewPreloads(style: PreloadStyles, options: PreloadOptions, re
}
const cell = new MarkupCell(init.cellId, init.mime, init.content, top);
cell.element.style.visibility = visible ? 'visible' : 'hidden';
this._markupCells.set(init.cellId, cell);
await cell.ready;
@ -939,11 +940,11 @@ async function webviewPreloads(style: PreloadStyles, options: PreloadOptions, re
await Promise.all(update.map(async info => {
let cell = this._markupCells.get(info.cellId);
if (cell) {
cell.element.style.visibility = info.visible ? 'visible' : 'hidden';
await cell.updateContentAndRender(info.content);
} else {
cell = await this.createMarkupCell(info, info.offset);
cell = await this.createMarkupCell(info, info.offset, info.visible);
}
cell.element.style.visibility = info.visible ? 'visible' : 'hidden';
}));
}