maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

fix memory leak

Browse source
This commit is contained in:
rebornix 2020-12-09 10:36:45 -08:00
parent 3c9a455470
commit 31d11a3729
2 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/vs/workbench/contrib/notebook/browser/diff/cellComponents.ts
View file

@ -124,11 +124,13 @@ class PropertyHeader extends Disposable {
return undefined;
}
});
this._register(this._toolbar);
this._toolbar.context = {
cell: this.cell
};
this._menu = this.menuService.createMenu(this.accessor.menuId, this.contextKeyService);
this._register(this._menu);
if (metadataChanged) {
const actions: IAction[] = [];

1
src/vs/workbench/contrib/notebook/browser/diff/notebookTextDiffList.ts
View file

@ -275,6 +275,7 @@ export class CellDiffSideBySideRenderer implements IListRenderer<CellDiffViewMod
disposeTemplate(templateData: CellDiffSideBySideRenderTemplate): void {
templateData.container.innerText = '';
templateData.sourceEditor.dispose();
templateData.toolbar?.dispose();
}
disposeElement(element: CellDiffViewModel, index: number, templateData: CellDiffSideBySideRenderTemplate): void {