maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Merge pull request #130317 from stevenguh/main

Browse source 
Fix failure to uninstall extension that has dependencies
This commit is contained in:
Sandeep Somavarapu 2021-08-17 11:34:07 +02:00 committed by GitHub
parent 67ef1fe123 146a0427ac
commit 323e53b38c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/vs/platform/extensionManagement/common/abstractExtensionManagementService.ts
View file

@ -469,7 +469,7 @@ export abstract class AbstractExtensionManagementService extends Disposable impl
for (const extension of extensionsToUninstall) {
const dependents = this.getDependents(extension, installed);
if (dependents.length) {
const remainingDependents = dependents.filter(dependent => extensionsToUninstall.indexOf(dependent) === -1);
const remainingDependents = dependents.filter(dependent => !extensionsToUninstall.some(e => areSameExtensions(e.identifier, dependent.identifier)));
if (remainingDependents.length) {
throw new Error(this.getDependentsErrorMessage(extension, remainingDependents, extensionToUninstall));
}