maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

no more usage of assert.equal, https://github.com/microsoft/vscode/issues/118667

Browse source
This commit is contained in:
Johannes Rieken 2021-03-30 09:55:49 +02:00
parent 2b04ebaa11
commit 3287cedd34
No known key found for this signature in database
GPG key ID: 96634B5AF12F8798
2 changed files with 20 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
src/vs/editor/contrib/snippet/test/snippetParser.test.ts
View file

@ -377,8 +377,6 @@ suite('SnippetParser', () => {
assert.strictEqual(marker[2].toString(), ')');
const placeholder = <Placeholder>marker[1];
// TODO @jrieken Making this strict causes cricular dependency
assert.equal(placeholder, false);
assert.strictEqual(placeholder.index, 1);
assert.strictEqual(placeholder.children.length, 3);
assert.ok(placeholder.children[0] instanceof Text);
@ -439,13 +437,13 @@ suite('SnippetParser', () => {
const [, p1, , p2] = new SnippetParser().parse('errorContext: `${1:err}`, error:$1').children;
assert.equal((<Placeholder>p1).index, 1);
assert.equal((<Placeholder>p1).children.length, 1);
assert.equal((<Text>(<Placeholder>p1).children[0]), 'err');
assert.strictEqual((<Placeholder>p1).index, 1);
assert.strictEqual((<Placeholder>p1).children.length, 1);
assert.strictEqual((<Text>(<Placeholder>p1).children[0]).toString(), 'err');
assert.equal((<Placeholder>p2).index, 1);
assert.equal((<Placeholder>p2).children.length, 1);
assert.equal((<Text>(<Placeholder>p2).children[0]), 'err');
assert.strictEqual((<Placeholder>p2).index, 1);
assert.strictEqual((<Placeholder>p2).children.length, 1);
assert.strictEqual((<Text>(<Placeholder>p2).children[0]).toString(), 'err');
});
// TODO @jrieken making this strictEqul causes circular json conversion errors
@ -455,15 +453,15 @@ suite('SnippetParser', () => {
const [, p3, , p4] = new SnippetParser().parse('errorContext: `${1:err}`, error:${1/err/ok/}').children;
assert.equal((<Placeholder>p3).index, 1);
assert.equal((<Placeholder>p3).children.length, 1);
assert.equal((<Text>(<Placeholder>p3).children[0]), 'err');
assert.equal((<Placeholder>p3).transform, undefined);
assert.strictEqual((<Placeholder>p3).index, 1);
assert.strictEqual((<Placeholder>p3).children.length, 1);
assert.strictEqual((<Text>(<Placeholder>p3).children[0]).toString(), 'err');
assert.strictEqual((<Placeholder>p3).transform, undefined);
assert.equal((<Placeholder>p4).index, 1);
assert.equal((<Placeholder>p4).children.length, 1);
assert.equal((<Text>(<Placeholder>p4).children[0]), 'err');
assert.notEqual((<Placeholder>p4).transform, undefined);
assert.strictEqual((<Placeholder>p4).index, 1);
assert.strictEqual((<Placeholder>p4).children.length, 1);
assert.strictEqual((<Text>(<Placeholder>p4).children[0]).toString(), 'err');
assert.notStrictEqual((<Placeholder>p4).transform, undefined);
});
test('Repeated snippet placeholder should always inherit, #31040', function () {

8
src/vs/editor/test/browser/services/openerService.test.ts
View file

@ -85,11 +85,15 @@ suite('OpenerService', function () {
assert.strictEqual(lastCommand!.id, id);
assert.strictEqual(lastCommand!.args.length, 0);
await openerService.open(URI.parse('command:' + id).with({ query: '\"123\"' }));
assert.strictEqual(lastCommand!.id, id);
assert.strictEqual(lastCommand!.args.length, 1);
assert.strictEqual(lastCommand!.args[0], '123');
await openerService.open(URI.parse('command:' + id).with({ query: '123' }));
assert.strictEqual(lastCommand!.id, id);
assert.strictEqual(lastCommand!.args.length, 1);
// TODO @jrieken is this ok that its converting the string to a number in the args?
assert.equal(lastCommand!.args[0], '123');
assert.strictEqual(lastCommand!.args[0], 123);
await openerService.open(URI.parse('command:' + id).with({ query: JSON.stringify([12, true]) }));
assert.strictEqual(lastCommand!.id, id);