maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Remove unnecessary layout call

Browse source
This commit is contained in:
Daniel Imms 2021-07-07 07:21:37 -07:00
parent 64081da3c8
commit 36ed3acc40
1 changed files with 1 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/vs/workbench/contrib/terminal/browser/terminalView.ts
View file

@ -53,7 +53,6 @@ export class TerminalViewPane extends ViewPane {
private _terminalTabbedView?: TerminalTabbedView;
get terminalTabbedView(): TerminalTabbedView | undefined { return this._terminalTabbedView; }
private _terminalsInitialized = false;
private _bodyDimensions: { width: number, height: number } = { width: 0, height: 0 };
private _isWelcomeShowing: boolean = false;
private _tabButtons: DropdownWithPrimaryActionViewItem | undefined;
private readonly _dropdownMenu: IMenu;
@ -147,9 +146,6 @@ export class TerminalViewPane extends ViewPane {
if (hadTerminals) {
this._terminalGroupService.activeGroup?.setVisible(visible);
} else {
// TODO@Tyriar - this call seems unnecessary
this.layoutBody(this._bodyDimensions.height, this._bodyDimensions.width);
}
this._terminalGroupService.showPanel(true);
} else {
@ -169,13 +165,7 @@ export class TerminalViewPane extends ViewPane {
// eslint-disable-next-line @typescript-eslint/naming-convention
protected override layoutBody(height: number, width: number): void {
super.layoutBody(height, width);
if (this._terminalTabbedView) {
this._bodyDimensions.width = width;
this._bodyDimensions.height = height;
this._terminalTabbedView.layout(width, height);
}
this._terminalTabbedView?.layout(width, height);
}
override getActionViewItem(action: Action): IActionViewItem | undefined {