From 3b44bb422d3dd68fa48572b2a2f9eb0db1ccb5d2 Mon Sep 17 00:00:00 2001 From: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Tue, 23 Mar 2021 07:56:59 -0700 Subject: [PATCH] Only set detected profile if value is non-null --- src/vs/workbench/contrib/terminal/node/terminalProfiles.ts | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/vs/workbench/contrib/terminal/node/terminalProfiles.ts b/src/vs/workbench/contrib/terminal/node/terminalProfiles.ts index 6e6a58a4457..9b95e66680a 100644 --- a/src/vs/workbench/contrib/terminal/node/terminalProfiles.ts +++ b/src/vs/workbench/contrib/terminal/node/terminalProfiles.ts @@ -201,8 +201,11 @@ async function detectAvailableUnixProfiles(statProvider: IStatProvider, logServi } for (const [profileName, value] of Object.entries(configProfiles || {})) { - if (value === null) { detectedProfiles.delete(profileName); } - detectedProfiles.set(profileName, value); + if (value === null) { + detectedProfiles.delete(profileName); + } else { + detectedProfiles.set(profileName, value); + } } return await transformToTerminalProfiles(detectedProfiles.entries(), statProvider, logService, variableResolver, workspaceFolder);