maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fixes #104004: Only run tests if the tests belong to a known extension

Browse source
This commit is contained in:
Alex Dima 2020-12-04 23:51:44 +01:00
parent dc8ac78031
commit 423bdb2e26
No known key found for this signature in database
GPG key ID: 6E58D7B045760DA0
1 changed files with 16 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/vs/workbench/api/common/extHostExtensionService.ts
View file

@ -35,6 +35,8 @@ import { IExtHostTunnelService } from 'vs/workbench/api/common/extHostTunnelServ
import { IExtHostTerminalService } from 'vs/workbench/api/common/extHostTerminalService';
import { Emitter, Event } from 'vs/base/common/event';
import { IExtensionActivationHost, checkActivateWorkspaceContainsExtension } from 'vs/workbench/api/common/shared/workspaceContains';
import { isEqualOrParent } from 'vs/base/common/extpath';
import { isLinux } from 'vs/base/common/platform';
interface ITestRunner {
/** Old test runner API, as exported from `vscode/lib/testrunner` */
@ -537,6 +539,20 @@ export abstract class AbstractExtHostExtensionService extends Disposable impleme
const extensionTestsPath = originalFSPath(extensionTestsLocationURI);
let knowsExtension = false;
for (const extension of this._registry.getAllExtensionDescriptions()) {
if (extension.extensionLocation.scheme === Schemas.file) {
const extensionPath = originalFSPath(extension.extensionLocation);
if (isEqualOrParent(extensionTestsPath, extensionPath, !isLinux)) {
knowsExtension = true;
}
}
}
if (!knowsExtension) {
return Promise.resolve(undefined);
}
// Require the test runner via node require from the provided path
let testRunner: ITestRunner | INewTestRunner | undefined;
let requireError: Error | undefined;