From 46234232d9c0ce97a6ae914719361bcf32b65175 Mon Sep 17 00:00:00 2001 From: Sofian Hnaide Date: Wed, 27 Jan 2016 16:16:45 -0800 Subject: [PATCH] fix #2400 Check that the user is internet-connected before loading the getting started page --- .../parts/gettingStarted/common/abstractGettingStarted.ts | 2 +- .../electron-browser/electronGettingStarted.ts | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/src/vs/workbench/parts/gettingStarted/common/abstractGettingStarted.ts b/src/vs/workbench/parts/gettingStarted/common/abstractGettingStarted.ts index 12c6c6321c6..f390376ac3d 100644 --- a/src/vs/workbench/parts/gettingStarted/common/abstractGettingStarted.ts +++ b/src/vs/workbench/parts/gettingStarted/common/abstractGettingStarted.ts @@ -32,7 +32,7 @@ export abstract class AbstractGettingStarted implements IWorkbenchContribution { } } - private handleWelcome(): void { + protected handleWelcome(): void { let firstStartup = !this.storageService.get(AbstractGettingStarted.hideWelcomeSettingskey); if (firstStartup && this.welcomePageURL) { diff --git a/src/vs/workbench/parts/gettingStarted/electron-browser/electronGettingStarted.ts b/src/vs/workbench/parts/gettingStarted/electron-browser/electronGettingStarted.ts index 72a4f453385..48c69ab2667 100644 --- a/src/vs/workbench/parts/gettingStarted/electron-browser/electronGettingStarted.ts +++ b/src/vs/workbench/parts/gettingStarted/electron-browser/electronGettingStarted.ts @@ -14,4 +14,11 @@ export class ElectronGettingStarted extends AbstractGettingStarted implements IW protected openExternal(url: string) { shell.openExternal(url); } + + protected handleWelcome(): void { + //make sure the user is online, otherwise refer to the next run to show the welcome page + if(navigator.onLine) { + super.handleWelcome(); + } + } } \ No newline at end of file