maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

fix serialization error

Browse source
This commit is contained in:
meganrogge 2021-06-15 06:16:17 -07:00
parent 0baba5e51e
commit 46877c9abc
No known key found for this signature in database
GPG key ID: 3155C8B2F0428C81
3 changed files with 6 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/vs/workbench/contrib/terminal/browser/terminalActions.ts
View file

@ -204,10 +204,9 @@ export function registerTerminalActions() {
});
}
async run(accessor: ServicesAccessor) {
const terminalService = accessor.get(ITerminalService);
const editorService = accessor.get(IEditorService);
const instantiationService = accessor.get(IInstantiationService);
const input = TerminalEditorInput.copy(terminalService, instantiationService);
const input = TerminalEditorInput.copy(instantiationService);
await editorService.openEditor(input, { pinned: true, forceReload: true });
}
});

2
src/vs/workbench/contrib/terminal/browser/terminalEditor.ts
View file

@ -75,6 +75,6 @@ export class TerminalInputSerializer implements IEditorInputSerializer {
}
public deserialize(instantiationService: IInstantiationService, serializedEditorInput: string): TerminalEditorInput {
throw new Error('not implemented');
return TerminalEditorInput.copy(instantiationService);
}
}

8
src/vs/workbench/contrib/terminal/browser/terminalEditorInput.ts
View file

@ -27,14 +27,14 @@ export class TerminalEditorInput extends EditorInput {
}
constructor(
instance: ITerminalInstance
@ITerminalService terminalService: ITerminalService
) {
super();
this._terminalInstance = instance;
this._terminalInstance = terminalService.createTerminal();
}
static copy(terminalService: ITerminalService, instantiationService: IInstantiationService): TerminalEditorInput {
return new TerminalEditorInput(terminalService.createInstance({}));
static copy(instantiationService: IInstantiationService): TerminalEditorInput {
return instantiationService.createInstance(TerminalEditorInput);
}
override getName() {