maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Use Set instead of array + object map

Browse source
This commit is contained in:
Matt Bierner 2019-07-01 17:04:00 -07:00
parent ae977ba1e0
commit 4727c9a045
1 changed files with 5 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/vs/workbench/services/themes/browser/workbenchThemeService.ts
View file

@ -372,18 +372,16 @@ export class WorkbenchThemeService implements IWorkbenchThemeService {
}
private updateDynamicCSSRules(themeData: ITheme) {
let cssRules: string[] = [];
let hasRule: { [rule: string]: boolean } = {};
let ruleCollector = {
const cssRules = new Set<string>();
const ruleCollector = {
addRule: (rule: string) => {
if (!hasRule[rule]) {
cssRules.push(rule);
hasRule[rule] = true;
if (!cssRules.has(rule)) {
cssRules.add(rule);
}
}
};
themingRegistry.getThemingParticipants().forEach(p => p(themeData, ruleCollector, this.environmentService));
_applyRules(cssRules.join('\n'), colorThemeRulesClassName);
_applyRules([...cssRules].join('\n'), colorThemeRulesClassName);
}
private applyTheme(newTheme: ColorThemeData, settingsTarget: ConfigurationTarget | undefined | 'auto', silent = false): Promise<IColorTheme | null> {