From 4c76edff2b378890335fc93ce53db0fb6bc9cad4 Mon Sep 17 00:00:00 2001 From: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Date: Wed, 31 Mar 2021 05:06:08 -0700 Subject: [PATCH] Revert "skip failing terminal tests." This reverts commit 2d5f0e495341144e6a8702183f753b0a339dc8e2. --- .../vscode-api-tests/src/singlefolder-tests/terminal.test.ts | 2 +- .../src/singlefolder-tests/workspace.tasks.test.ts | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/extensions/vscode-api-tests/src/singlefolder-tests/terminal.test.ts b/extensions/vscode-api-tests/src/singlefolder-tests/terminal.test.ts index e65983f4775..e5b7a74623f 100644 --- a/extensions/vscode-api-tests/src/singlefolder-tests/terminal.test.ts +++ b/extensions/vscode-api-tests/src/singlefolder-tests/terminal.test.ts @@ -58,7 +58,7 @@ import { assertNoRpc } from '../utils'; }); }); - test.skip('echo works in the default shell', async () => { + test('echo works in the default shell', async () => { const terminal = await new Promise(r => { disposables.push(window.onDidOpenTerminal(t => { if (t === terminal) { diff --git a/extensions/vscode-api-tests/src/singlefolder-tests/workspace.tasks.test.ts b/extensions/vscode-api-tests/src/singlefolder-tests/workspace.tasks.test.ts index cd9c92d7d18..b9e0bd7b586 100644 --- a/extensions/vscode-api-tests/src/singlefolder-tests/workspace.tasks.test.ts +++ b/extensions/vscode-api-tests/src/singlefolder-tests/workspace.tasks.test.ts @@ -33,7 +33,7 @@ import { assertNoRpc } from '../utils'; }); suite('ShellExecution', () => { - test.skip('Execution from onDidEndTaskProcess and onDidStartTaskProcess are equal to original', () => { + test('Execution from onDidEndTaskProcess and onDidStartTaskProcess are equal to original', () => { return new Promise(async (resolve) => { const task = new Task({ type: 'testTask' }, TaskScope.Workspace, 'echo', 'testTask', new ShellExecution('echo', ['hello test'])); let taskExecution: TaskExecution | undefined; @@ -76,7 +76,7 @@ import { assertNoRpc } from '../utils'; }); }); - test.skip('dependsOn task should start with a different processId (#118256)', async () => { + test('dependsOn task should start with a different processId (#118256)', async () => { // Set up dependsOn task by creating tasks.json since this is not possible via the API // Tasks API const tasksConfig = workspace.getConfiguration('tasks');