maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Remove version gating on for now enableProjectDiagnostics

Browse source 
None of the apis being users for this experimental setting require the latest TS version
This commit is contained in:
Matt Bierner 2020-02-06 16:32:56 -08:00
parent 7cb5172397
commit 4d35421462
2 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
extensions/typescript-language-features/package.nls.json
View file

@ -58,7 +58,7 @@
"configuration.suggest.paths": "Enable/disable suggestions for paths in import statements and require calls.",
"configuration.tsserver.useSeparateSyntaxServer": "Enable/disable spawning a separate TypeScript server that can more quickly respond to syntax related operations, such as calculating folding or computing document symbols. Requires using TypeScript 3.4.0 or newer in the workspace.",
"configuration.tsserver.maxTsServerMemory": "Set the maximum amount of memory (in MB) to allocate to the TypeScript server process",
"configuration.tsserver.experimental.enableProjectDiagnostics": "(Experimental) Enables project wide error reporting. Requires using TypeScript 3.8 or newer in the workspace.",
"configuration.tsserver.experimental.enableProjectDiagnostics": "(Experimental) Enables project wide error reporting.",
"typescript.locale": "Sets the locale used to report JavaScript and TypeScript errors. Requires using TypeScript 2.6.0 or newer in the workspace. Default of `null` uses VS Code's locale.",
"javascript.implicitProjectConfig.experimentalDecorators": "Enable/disable `experimentalDecorators` for JavaScript files that are not part of a project. Existing jsconfig.json or tsconfig.json files override this setting. Requires using TypeScript 2.3.1 or newer in the workspace.",
"configuration.suggest.autoImports": "Enable/disable auto import suggestions. Requires using TypeScript 2.6.1 or newer in the workspace.",

5
extensions/typescript-language-features/src/tsServer/spawner.ts
View file

@ -53,7 +53,7 @@ export class TypeScriptServerSpawner {
primaryServer = this.spawnTsServer(ServerKind.Main, version, configuration, pluginManager);
}
if (this.shouldUseSeparateDiagnosticsServer(version, configuration)) {
if (this.shouldUseSeparateDiagnosticsServer(configuration)) {
return new GetErrRoutingTsServer({
getErr: this.spawnTsServer(ServerKind.Diagnostics, version, configuration, pluginManager),
primary: primaryServer,
@ -71,10 +71,9 @@ export class TypeScriptServerSpawner {
}
private shouldUseSeparateDiagnosticsServer(
version: TypeScriptVersion,
configuration: TypeScriptServiceConfiguration,
): boolean {
return configuration.enableProjectDiagnostics && !!version.apiVersion && version.apiVersion.gte(API.v380);
return configuration.enableProjectDiagnostics;
}
private spawnTsServer(