maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

handle 4XX errors differently from others

Browse source
This commit is contained in:
Tyler Leonhardt 2021-11-22 16:20:47 -08:00
parent bea3784159
commit 53e8f2c26e
No known key found for this signature in database
GPG key ID: 1BC2B6244363E77E
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
extensions/microsoft-authentication/src/AADHelper.ts
View file

@ -619,7 +619,7 @@ export class AzureActiveDirectoryService {
errorMessage = e.message ?? e;
}
if (!result || !result.ok) {
if (!result || result.status > 499) {
if (attempts > 3) {
Logger.error(`Fetching token failed for scopes (${scopes}): ${result ? await result.text() : errorMessage}`);
break;
@ -627,6 +627,11 @@ export class AzureActiveDirectoryService {
// Exponential backoff
await new Promise(resolve => setTimeout(resolve, 5 * attempts * attempts * 1000));
continue;
} else if (!result.ok) {
// For 4XX errors, the user may actually have an expired token or have changed
// their password recently which is throwing a 4XX. For this, we throw an error
// so that the user can be prompted to sign in again.
throw new Error(await result.text());
}
return await result.json() as ITokenResponse;