maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Add check to ensure RC and forward use '--serverMode'. (#104123)

Browse source
This commit is contained in:
Daniel Rosenwasser 2020-08-05 15:26:59 -07:00 committed by GitHub
parent ddc794ab8b
commit 54a38a2ee9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
extensions/typescript-language-features/src/tsServer/spawner.ts
View file

@ -18,6 +18,7 @@ import { ILogDirectoryProvider } from './logDirectoryProvider';
import { GetErrRoutingTsServer, ITypeScriptServer, ProcessBasedTsServer, SyntaxRoutingTsServer, TsServerDelegate, TsServerProcessFactory, TsServerProcessKind } from './server';
import { TypeScriptVersionManager } from './versionManager';
import { ITypeScriptVersionProvider, TypeScriptVersion } from './versionProvider';
import * as semver from 'semver';
const enum CompositeServerType {
/** Run a single server that handles all commands */
@ -163,7 +164,13 @@ export class TypeScriptServerSpawner {
let tsServerLogFile: string | undefined;
if (kind === TsServerProcessKind.Syntax) {
args.push('--syntaxOnly');
if (semver.gte(API.v400rc.fullVersionString, apiVersion.fullVersionString)) {
args.push('--serverMode');
args.push('partialSemantic');
}
else {
args.push('--syntaxOnly');
}
}
if (apiVersion.gte(API.v250)) {

1
extensions/typescript-language-features/src/utils/api.ts
View file

@ -34,6 +34,7 @@ export default class API {
public static readonly v380 = API.fromSimpleString('3.8.0');
public static readonly v381 = API.fromSimpleString('3.8.1');
public static readonly v390 = API.fromSimpleString('3.9.0');
public static readonly v400rc = API.fromSimpleString('4.0.0-rc');
public static readonly v400 = API.fromSimpleString('4.0.0');
public static fromVersionString(versionString: string): API {