maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Use _register for disposable

Browse source 
This class already extends `Disposable` so we should just use `_register` insteaed of reimplementing `dispose`
This commit is contained in:
Matt Bierner 2021-03-03 18:16:47 -08:00
parent 538931e790
commit 584d233887
1 changed files with 2 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/vs/workbench/contrib/notebook/browser/view/renderers/markdownCell.ts
View file

@ -36,13 +36,14 @@ class WebviewMarkdownRenderer extends Disposable implements IMarkdownRenderStrat
) {
super();
}
update(): void {
this.notebookEditor.createMarkdownPreview(this.viewCell);
}
}
class BuiltinMarkdownRenderer extends Disposable implements IMarkdownRenderStrategy {
private readonly localDisposables = new DisposableStore();
private readonly localDisposables = this._register(new DisposableStore());
constructor(
private readonly notebookEditor: IActiveNotebookEditor,
@ -60,11 +61,6 @@ class BuiltinMarkdownRenderer extends Disposable implements IMarkdownRenderStrat
})).startObserving();
}
dispose(): void {
this.localDisposables.dispose();
super.dispose();
}
update(): void {
const markdownRenderer = this.viewCell.getMarkdownRenderer();