maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Add logging of PATH to investigate ATA issues reported in #24961

Browse source
This commit is contained in:
Matt Bierner 2017-05-15 21:46:21 -07:00
parent ed16aff923
commit 613724d43b
2 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
extensions/typescript/src/typescriptServiceClient.ts
View file

@ -543,7 +543,7 @@ export default class TypeScriptServiceClient implements ITypescriptServiceClient
}
}
electron.fork(modulePath, args, options, (err: any, childProcess: cp.ChildProcess) => {
electron.fork(modulePath, args, options, this.logger, (err: any, childProcess: cp.ChildProcess) => {
if (err) {
this.lastError = err;
this.error('Starting TSServer failed with error.', err);

7
extensions/typescript/src/utils/electron.ts
View file

@ -9,6 +9,7 @@ import path = require('path');
import os = require('os');
import net = require('net');
import cp = require('child_process');
import Logger from './logger';
export interface IForkOptions {
cwd?: string;
@ -60,7 +61,8 @@ export function fork(
modulePath: string,
args: string[],
options: IForkOptions,
callback: (error: any, cp: cp.ChildProcess | null) => void
logger: Logger,
callback: (error: any, cp: cp.ChildProcess | null) => void,
): void {
var callbackCalled = false;
@ -86,7 +88,6 @@ export function fork(
const newEnv = generatePatchedEnv(process.env, stdInPipeName, stdOutPipeName, stdErrPipeName);
var childProcess: cp.ChildProcess;
// Begin listening to stderr pipe
@ -123,6 +124,8 @@ export function fork(
};
// Create the process
logger.info('Forking TSServer', `PATH: ${newEnv['PATH']}`);
const bootstrapperPath = path.join(__dirname, 'electronForkStart');
childProcess = cp.fork(bootstrapperPath, [modulePath].concat(args), <any>{
silent: true,