maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fixes #38793: Environment variables not persisted across task chains

Browse source
This commit is contained in:
Dirk Baeumer 2017-11-21 11:13:17 +01:00
parent fee8c6336e
commit 61a5ea9cc7
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/vs/workbench/parts/tasks/node/taskConfiguration.ts
View file

@ -810,6 +810,10 @@ namespace CommandConfiguration {
return isEmpty(result) ? undefined : result;
}
export function hasCommand(value: Tasks.CommandConfiguration): boolean {
return value && !!value.name;
}
export function isEmpty(value: Tasks.CommandConfiguration): boolean {
return _isEmpty(value, properties);
}
@ -1278,7 +1282,8 @@ namespace CustomTask {
export function fillGlobals(task: Tasks.CustomTask, globals: Globals): void {
// We only merge a command from a global definition if there is no dependsOn
if (task.dependsOn === void 0) {
// or there is a dependsOn and a defined command.
if (CommandConfiguration.hasCommand(task.command) || task.dependsOn === void 0) {
task.command = CommandConfiguration.fillGlobals(task.command, globals.command, task.name);
}
// promptOnClose is inferred from isBackground if available