maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Keep misspelled property name in timerService

Browse source 
Per https://github.com/microsoft/vscode/pull/116728#pullrequestreview-590976270.
This commit is contained in:
Utku Gultopu 2021-02-16 11:48:03 -05:00
parent bf0e8299db
commit 68b67a3455
3 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/vs/workbench/contrib/performance/browser/perfviewEditor.ts
View file

@ -156,7 +156,7 @@ class PerfModelContentProvider implements ITextModelContentProvider {
if (metrics.meminfo) {
md.li(`Memory(Process): ${(metrics.meminfo.workingSetSize / ByteSize.KB).toFixed(2)} MB working set(${(metrics.meminfo.privateBytes / ByteSize.KB).toFixed(2)}MB private, ${(metrics.meminfo.sharedBytes / ByteSize.KB).toFixed(2)}MB shared)`);
}
md.li(`VM(likelihood): ${metrics.isVMLikelihood}%`);
md.li(`VM(likelihood): ${metrics.isVMLikelyhood}%`);
md.li(`Initial Startup: ${metrics.initialStartup}`);
md.li(`Has ${metrics.windowCount - 1} other windows`);
md.li(`Screen Reader Active: ${metrics.hasAccessibilitySupport}`);

8
src/vs/workbench/services/timer/browser/timerService.ts
View file

@ -68,7 +68,7 @@ export interface IMemoryInfo {
"cpus.model" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" },
"initialStartup" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth", "isMeasurement": true },
"hasAccessibilitySupport" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth", "isMeasurement": true },
"isVMLikelihood" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth", "isMeasurement": true },
"isVMLikelyhood" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth", "isMeasurement": true },
"emptyWorkbench" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth", "isMeasurement": true },
"loadavg" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" }
}
@ -324,7 +324,7 @@ export interface IStartupMetrics {
};
readonly hasAccessibilitySupport: boolean;
readonly isVMLikelihood?: number;
readonly isVMLikelyhood?: number;
readonly platform?: string;
readonly release?: string;
readonly arch?: string;
@ -546,7 +546,7 @@ export abstract class AbstractTimerService implements ITimerService {
meminfo: undefined,
cpus: undefined,
loadavg: undefined,
isVMLikelihood: undefined,
isVMLikelyhood: undefined,
initialStartup,
hasAccessibilitySupport: this._accessibilityService.isScreenReaderOptimized(),
emptyWorkbench: this._contextService.getWorkbenchState() === WorkbenchState.EMPTY
@ -578,7 +578,7 @@ export class TimerService extends AbstractTimerService {
return 1;
}
protected async _extendStartupInfo(info: Writeable<IStartupMetrics>): Promise<void> {
info.isVMLikelihood = 0;
info.isVMLikelyhood = 0;
info.platform = navigator.userAgent;
info.release = navigator.appVersion;
}

2
src/vs/workbench/services/timer/electron-sandbox/timerService.ts
View file

@ -68,7 +68,7 @@ export class TimerService extends AbstractTimerService {
sharedBytes: processMemoryInfo.shared
};
info.isVMLikelihood = Math.round((virtualMachineHint * 100));
info.isVMLikelyhood = Math.round((virtualMachineHint * 100));
const rawCpus = osProperties.cpus;
if (rawCpus && rawCpus.length > 0) {