remove legacy API

This commit is contained in:
rebornix 2020-05-20 09:02:39 -07:00
parent cb1c577e76
commit 6db9773a32
2 changed files with 4 additions and 7 deletions

View file

@ -1912,11 +1912,6 @@ declare module 'vscode' {
// backup?(document: NotebookDocument, cancellation: CancellationToken): Thenable<CustomDocumentBackup>;
kernel?: NotebookKernel;
/**
* Responsible for filling in outputs for the cell
*/
executeCell(document: NotebookDocument, cell: NotebookCell | undefined, token: CancellationToken): Promise<void>;
}
export interface NotebookKernel {

View file

@ -807,6 +807,10 @@ export class ExtHostNotebookController implements ExtHostNotebookShape, ExtHostN
throw new Error(`Notebook provider for '${viewType}' already registered`);
}
if ((<any>provider).executeCell) {
throw new Error('NotebookContentKernel.executeCell is removed, please use vscode.notebook.registerNotebookKernel instead.');
}
this._notebookContentProviders.set(viewType, { extension, provider });
this._proxy.$registerNotebookProvider({ id: extension.identifier, location: extension.extensionLocation }, viewType, provider.kernel ? { id: viewType, label: provider.kernel.label, extensionLocation: extension.extensionLocation, preloads: provider.kernel.preloads } : undefined);
return new extHostTypes.Disposable(() => {
@ -963,8 +967,6 @@ export class ExtHostNotebookController implements ExtHostNotebookShape, ExtHostN
} else {
return provider.kernel.executeAllCells(document, token);
}
} else {
return provider.executeCell(document, cell, token);
}
}
}