maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

notificationTelemetry: id should always be a string

Browse source
This commit is contained in:
isidor 2021-03-23 15:50:07 +01:00
parent 4eb625f0cf
commit 75f796dfb4
No known key found for this signature in database
GPG key ID: F9280366A8370105
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/vs/workbench/browser/parts/notifications/notificationsActions.ts
View file

@ -147,7 +147,7 @@ export class CopyNotificationMessageAction extends Action {
}
interface NotificationActionMetrics {
id: number;
id: string;
actionLabel: string;
source: string | undefined;
}
@ -170,7 +170,7 @@ export class NotificationActionRunner extends ActionRunner {
this.telemetryService.publicLog2<WorkbenchActionExecutedEvent, WorkbenchActionExecutedClassification>('workbenchActionExecuted', { id: action.id, from: 'message' });
if (context) {
// If the context is not present it is a "global" notification action. Will be captured by other events
this.telemetryService.publicLog2<NotificationActionMetrics, NotificationActionMetricsClassification>('notification:actionExecuted', { id: hash(context.message.original.toString()), actionLabel: action.label, source: context.sourceId });
this.telemetryService.publicLog2<NotificationActionMetrics, NotificationActionMetricsClassification>('notification:actionExecuted', { id: hash(context.message.original.toString()).toString(), actionLabel: action.label, source: context.sourceId });
}
// Run and make sure to notify on any error again