From 7ae734397319eb746ef03f9d3e9d71b49d114e4d Mon Sep 17 00:00:00 2001 From: Matt Bierner Date: Wed, 8 Apr 2020 18:06:24 -0700 Subject: [PATCH] Fix some strict null errors revealed by change to emitter --- extensions/npm/src/npmView.ts | 2 +- .../typescript-language-features/src/typescriptServiceClient.ts | 2 +- .../vscode-api-tests/src/singlefolder-tests/terminal.test.ts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/extensions/npm/src/npmView.ts b/extensions/npm/src/npmView.ts index bcb1d9c9876..0a4908ec440 100644 --- a/extensions/npm/src/npmView.ts +++ b/extensions/npm/src/npmView.ts @@ -225,7 +225,7 @@ export class NpmScriptsTreeDataProvider implements TreeDataProvider { public refresh() { this.taskTree = null; - this._onDidChangeTreeData.fire(); + this._onDidChangeTreeData.fire(null); } getTreeItem(element: TreeItem): TreeItem { diff --git a/extensions/typescript-language-features/src/typescriptServiceClient.ts b/extensions/typescript-language-features/src/typescriptServiceClient.ts index a8e36109503..2b5ba716d21 100644 --- a/extensions/typescript-language-features/src/typescriptServiceClient.ts +++ b/extensions/typescript-language-features/src/typescriptServiceClient.ts @@ -405,7 +405,7 @@ export default class TypeScriptServiceClient extends Disposable implements IType handle.onEvent(event => this.dispatchEvent(event)); this._onReady!.resolve(); - this._onTsServerStarted.fire(version.apiVersion); + this._onTsServerStarted.fire(apiVersion); if (apiVersion.gte(API.v300)) { this.loadingIndicator.startedLoadingProject(undefined /* projectName */); diff --git a/extensions/vscode-api-tests/src/singlefolder-tests/terminal.test.ts b/extensions/vscode-api-tests/src/singlefolder-tests/terminal.test.ts index 9f45c7b8897..52bfe1f1d9d 100644 --- a/extensions/vscode-api-tests/src/singlefolder-tests/terminal.test.ts +++ b/extensions/vscode-api-tests/src/singlefolder-tests/terminal.test.ts @@ -440,7 +440,7 @@ import { doesNotThrow, equal, ok, deepEqual, throws } from 'assert'; const pty: Pseudoterminal = { onDidWrite: writeEmitter.event, onDidClose: closeEmitter.event, - open: () => closeEmitter.fire(), + open: () => closeEmitter.fire(undefined), close: () => { } }; const terminal = window.createTerminal({ name: 'foo', pty });