maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Rename implicit project settings and deprecate old ones

Browse source 
For #109990
This commit is contained in:
Matt Bierner 2020-11-04 14:55:28 -08:00
parent ff7cc33236
commit 81a25a894c
3 changed files with 22 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
extensions/typescript-language-features/package.json
View file

@ -505,10 +505,24 @@
"javascript.implicitProjectConfig.checkJs": {
"type": "boolean",
"default": false,
"description": "%javascript.implicitProjectConfig.checkJs%",
"markdownDescription": "%configuration.implicitProjectConfig.checkJs%",
"markdownDeprecationMessage": "%configuration.javascript.checkJs.checkJs.deprecation%",
"scope": "window"
},
"js/ts.implicitProjectConfig.checkJs": {
"type": "boolean",
"default": false,
"markdownDescription": "%configuration.implicitProjectConfig.checkJs%",
"scope": "window"
},
"javascript.implicitProjectConfig.experimentalDecorators": {
"type": "boolean",
"default": false,
"markdownDescription": "%configuration.implicitProjectConfig.experimentalDecorators%",
"markdownDeprecationMessage": "%configuration.javascript.implicitProjectConfig.experimentalDecorators.deprecation%",
"scope": "window"
},
"js/ts.implicitProjectConfig.experimentalDecorators": {
"type": "boolean",
"default": false,
"markdownDescription": "%configuration.implicitProjectConfig.experimentalDecorators%",

4
extensions/typescript-language-features/package.nls.json
View file

@ -46,7 +46,6 @@
"typescript.restartTsServer": "Restart TS server",
"typescript.selectTypeScriptVersion.title": "Select TypeScript Version...",
"typescript.reportStyleChecksAsWarnings": "Report style checks as warnings.",
"javascript.implicitProjectConfig.checkJs": "Enable/disable semantic checking of JavaScript files. Existing jsconfig.json or tsconfig.json files override this setting.",
"typescript.npm": "Specifies the path to the npm executable used for Automatic Type Acquisition.",
"typescript.check.npmIsInstalled": "Check if npm is installed for Automatic Type Acquisition.",
"configuration.suggest.names": "Enable/disable including unique names from the file in JavaScript suggestions. Note that name suggestions are always disabled in JavaScript code that is semantically checked using `@ts-check` or `checkJs`.",
@ -62,7 +61,10 @@
"configuration.tsserver.maxTsServerMemory": "Set the maximum amount of memory (in MB) to allocate to the TypeScript server process",
"configuration.tsserver.experimental.enableProjectDiagnostics": "(Experimental) Enables project wide error reporting.",
"typescript.locale": "Sets the locale used to report JavaScript and TypeScript errors. Default of `null` uses VS Code's locale.",
"configuration.implicitProjectConfig.checkJs": "Enable/disable semantic checking of JavaScript files. Existing `jsconfig.json` or `tsconfig.json` files override this setting.",
"configuration.javascript.checkJs.checkJs.deprecation": "This setting has been deprecated in favor of `#js/ts.implicitProjectConfig.checkJs#`.",
"configuration.implicitProjectConfig.experimentalDecorators": "Enable/disable `experimentalDecorators` in JavaScript files that are not part of a project. Existing `jsconfig.json` or `tsconfig.json` files override this setting.",
"configuration.javascript.checkJs.experimentalDecorators.deprecation": "This setting has been deprecated in favor of `#js/ts.implicitProjectConfig.experimentalDecorators#`.",
"configuration.implicitProjectConfig.strictNullChecks": "Enable/disable [strict null checks](https://www.typescriptlang.org/tsconfig#strictNullChecks) in JavaScript and TypeScript files that are not part of a project. Existing `jsconfig.json` or `tsconfig.json` files override this setting.",
"configuration.implicitProjectConfig.strictFunctionTypes": "Enable/disable [strict function types](https://www.typescriptlang.org/tsconfig#strictFunctionTypes) in JavaScript and TypeScript files that are not part of a project. Existing `jsconfig.json` or `tsconfig.json` files override this setting.",
"configuration.suggest.autoImports": "Enable/disable auto import suggestions.",

6
extensions/typescript-language-features/src/utils/configuration.ts
View file

@ -69,11 +69,13 @@ export class ImplicitProjectConfiguration {
}
private static readCheckJs(configuration: vscode.WorkspaceConfiguration): boolean {
return configuration.get<boolean>('javascript.implicitProjectConfig.checkJs', false);
return configuration.get<boolean>('js/ts.implicitProjectConfig.checkJs')
?? configuration.get<boolean>('javascript.implicitProjectConfig.checkJs', false);
}
private static readExperimentalDecorators(configuration: vscode.WorkspaceConfiguration): boolean {
return configuration.get<boolean>('javascript.implicitProjectConfig.experimentalDecorators', false);
return configuration.get<boolean>('js/ts.implicitProjectConfig.experimentalDecorators')
?? configuration.get<boolean>('javascript.implicitProjectConfig.experimentalDecorators', false);
}
private static readImplicitStrictNullChecks(configuration: vscode.WorkspaceConfiguration): boolean {