maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

fix https://github.com/microsoft/vscode/issues/122270

Browse source
This commit is contained in:
Johannes Rieken 2021-04-28 11:32:29 +02:00
parent 5688d75ef9
commit 8420e94d8d
No known key found for this signature in database
GPG key ID: 96634B5AF12F8798
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/vs/workbench/contrib/notebook/test/notebookEditorKernelManager.test.ts
View file

@ -59,7 +59,7 @@ suite('NotebookEditorKernelManager', () => {
await withTestNotebook(
[],
async (viewModel) => {
const kernelManager = instantiationService.createInstance(NotebookEditorKernelManager, { activeKernel: undefined, viewModel });
const kernelManager = instantiationService.createInstance(NotebookEditorKernelManager);
const cell = viewModel.createCell(1, 'var c = 3', 'javascript', CellKind.Code, {}, [], true);
await assertThrowsAsync(async () => await kernelManager.executeNotebookCell(cell));

4
src/vs/workbench/contrib/notebook/test/notebookKernelService.test.ts
View file

@ -140,7 +140,7 @@ suite('NotebookKernelService', () => {
{
// open as jupyter -> bind event
const p1 = Event.toPromise(kernelService.onDidChangeNotebookKernelBinding);
const d1 = instantiationService.createInstance(NotebookTextModel, jupyter.viewType, jupyter.uri, [], {});
const d1 = instantiationService.createInstance(NotebookTextModel, jupyter.viewType, jupyter.uri, [], {}, {});
onDidAddNotebookDocument.fire(d1);
const event = await p1;
assert.strictEqual(event.newKernel, jupyterKernel.id);
@ -148,7 +148,7 @@ suite('NotebookKernelService', () => {
{
// RE-open as dotnet -> bind event
const p2 = Event.toPromise(kernelService.onDidChangeNotebookKernelBinding);
const d2 = instantiationService.createInstance(NotebookTextModel, dotnet.viewType, dotnet.uri, [], {});
const d2 = instantiationService.createInstance(NotebookTextModel, dotnet.viewType, dotnet.uri, [], {}, {});
onDidAddNotebookDocument.fire(d2);
const event2 = await p2;
assert.strictEqual(event2.newKernel, dotnetKernel.id);