maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

better keybinding rendering in suggest status bar

Browse source
This commit is contained in:
Johannes Rieken 2021-06-30 17:35:21 +02:00
parent b64c52be11
commit 84323a8046
No known key found for this signature in database
GPG key ID: 96634B5AF12F8798
1 changed files with 13 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
src/vs/editor/contrib/suggest/suggestWidgetStatus.ts
View file

@ -14,11 +14,22 @@ import { MenuEntryActionViewItem } from 'vs/platform/actions/browser/menuEntryAc
import { IMenuService, MenuItemAction } from 'vs/platform/actions/common/actions';
import { IContextKeyService } from 'vs/platform/contextkey/common/contextkey';
import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation';
import { IKeybindingService } from 'vs/platform/keybinding/common/keybinding';
import { INotificationService } from 'vs/platform/notification/common/notification';
class StatusBarViewItem extends MenuEntryActionViewItem {
constructor(
action: MenuItemAction,
@IKeybindingService keybindingService: IKeybindingService,
@INotificationService notificationService: INotificationService,
@IContextKeyService private _contextKeyService: IContextKeyService,
) {
super(action, undefined, keybindingService, notificationService);
}
override updateLabel() {
const kb = this._keybindingService.lookupKeybinding(this._action.id);
const kb = this._keybindingService.lookupKeybinding(this._action.id, this._contextKeyService);
if (!kb) {
return super.updateLabel();
}
@ -49,7 +60,7 @@ export class SuggestWidgetStatus {
this.element = dom.append(container, dom.$('.suggest-status-bar'));
const actionViewItemProvider = <IActionViewItemProvider>(action => {
return action instanceof MenuItemAction ? instantiationService.createInstance(StatusBarViewItem, action, undefined) : undefined;
return action instanceof MenuItemAction ? instantiationService.createInstance(StatusBarViewItem, action) : undefined;
});
this._leftActions = new ActionBar(this.element, { actionViewItemProvider });
this._rightActions = new ActionBar(this.element, { actionViewItemProvider });