maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

fix #57661

Browse source
This commit is contained in:
Benjamin Pasero 2018-09-06 09:37:16 +02:00
parent f0a966b570
commit 84cd128e93
1 changed files with 0 additions and 94 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

94
src/vs/workbench/services/editor/test/browser/editorService.test.ts
View file

@ -307,100 +307,6 @@ suite('Editor service', () => {
});
});
// test('close editor does not dispose when editor opened in other group (diff input)', function () {
// const partInstantiator = workbenchInstantiationService();
// const part = partInstantiator.createInstance(EditorPart, 'id', false);
// part.create(document.createElement('div'));
// part.layout(new Dimension(400, 300));
// const testInstantiationService = partInstantiator.createChild(new ServiceCollection([IEditorGroupsService, part]));
// const service: IEditorService = testInstantiationService.createInstance(EditorService);
// const input = testInstantiationService.createInstance(TestEditorInput, URI.parse('my://resource-close2'));
// const otherInput = testInstantiationService.createInstance(TestEditorInput, URI.parse('my://resource2-close2'));
// const diffInput = new DiffEditorInput('name', 'description', input, otherInput);
// const rootGroup = part.activeGroup;
// const rightGroup = part.addGroup(rootGroup, GroupDirection.RIGHT);
// // Open input
// return service.openEditor(diffInput, { pinned: true }).then(editor => {
// return service.openEditor(diffInput, { pinned: true }, rightGroup).then(editor => {
// // Close input
// return rootGroup.closeEditor(diffInput).then(() => {
// assert.equal(diffInput.isDisposed(), false);
// assert.equal(input.isDisposed(), false);
// assert.equal(otherInput.isDisposed(), false);
// return rightGroup.closeEditor(diffInput).then(() => {
// assert.equal(diffInput.isDisposed(), true);
// assert.equal(input.isDisposed(), true);
// assert.equal(otherInput.isDisposed(), true);
// });
// });
// });
// });
// });
// test('close editor disposes properly (diff input)', function () {
// const partInstantiator = workbenchInstantiationService();
// const part = partInstantiator.createInstance(EditorPart, 'id', false);
// part.create(document.createElement('div'));
// part.layout(new Dimension(400, 300));
// const testInstantiationService = partInstantiator.createChild(new ServiceCollection([IEditorGroupsService, part]));
// const service: IEditorService = testInstantiationService.createInstance(EditorService);
// const input = testInstantiationService.createInstance(TestEditorInput, URI.parse('my://resource-close3'));
// const otherInput = testInstantiationService.createInstance(TestEditorInput, URI.parse('my://resource2-close3'));
// const diffInput = new DiffEditorInput('name', 'description', input, otherInput);
// // Open input
// return service.openEditor(diffInput, { pinned: true }).then(editor => {
// // Close input
// return editor.group.closeEditor(diffInput).then(() => {
// assert.equal(diffInput.isDisposed(), true);
// assert.equal(otherInput.isDisposed(), true);
// assert.equal(input.isDisposed(), true);
// });
// });
// });
// test('close editor disposes properly (diff input, left side still opened)', function () {
// const partInstantiator = workbenchInstantiationService();
// const part = partInstantiator.createInstance(EditorPart, 'id', false);
// part.create(document.createElement('div'));
// part.layout(new Dimension(400, 300));
// const testInstantiationService = partInstantiator.createChild(new ServiceCollection([IEditorGroupsService, part]));
// const service: IEditorService = testInstantiationService.createInstance(EditorService);
// const input = testInstantiationService.createInstance(TestEditorInput, URI.parse('my://resource-close4'));
// const otherInput = testInstantiationService.createInstance(TestEditorInput, URI.parse('my://resource2-close4'));
// const diffInput = new DiffEditorInput('name', 'description', input, otherInput);
// // Open input
// return service.openEditor(diffInput, { pinned: true }).then(editor => {
// return service.openEditor(input, { pinned: true }).then(editor => {
// // Close input
// return editor.group.closeEditor(diffInput).then(() => {
// assert.equal(diffInput.isDisposed(), true);
// assert.equal(otherInput.isDisposed(), true);
// assert.equal(input.isDisposed(), false);
// });
// });
// });
// });
test('open to the side', function () {
const partInstantiator = workbenchInstantiationService();