From 86ceb0c84eab5ca7ed3ab1e5cc576ec4e0ae7284 Mon Sep 17 00:00:00 2001 From: Matt Bierner Date: Mon, 1 Oct 2018 16:01:28 -0700 Subject: [PATCH] Enable noUnusedParameters in configurationHelper --- .../configuration-editing/src/extension.ts | 28 +++++++++---------- .../src/settingsDocumentHelper.ts | 6 ++-- .../configuration-editing/tsconfig.json | 3 +- 3 files changed, 19 insertions(+), 18 deletions(-) diff --git a/extensions/configuration-editing/src/extension.ts b/extensions/configuration-editing/src/extension.ts index 0d782d60838..6160ac77b53 100644 --- a/extensions/configuration-editing/src/extension.ts +++ b/extensions/configuration-editing/src/extension.ts @@ -70,7 +70,7 @@ function autoFixSettingsJSON(willSaveEvent: vscode.TextDocumentWillSaveEvent): v lastEndOfSomething = offset + length; }, - onLiteralValue(value: any, offset: number, length: number): void { + onLiteralValue(_value: any, offset: number, length: number): void { lastEndOfSomething = offset + length; }, @@ -78,7 +78,7 @@ function autoFixSettingsJSON(willSaveEvent: vscode.TextDocumentWillSaveEvent): v lastEndOfSomething = offset + length; }, - onError(error: ParseErrorCode, offset: number, length: number): void { + onError(error: ParseErrorCode, _offset: number, _length: number): void { if (error === ParseErrorCode.CommaExpected && lastEndOfSomething > -1) { const fixPosition = document.positionAt(lastEndOfSomething); @@ -100,7 +100,7 @@ function registerKeybindingsCompletions(): vscode.Disposable { return vscode.languages.registerCompletionItemProvider({ pattern: '**/keybindings.json' }, { - provideCompletionItems(document, position, token) { + provideCompletionItems(document, position, _token) { const location = getLocation(document.getText(), document.offsetAt(position)); if (location.path[1] === 'command') { @@ -121,7 +121,7 @@ function registerSettingsCompletions(): vscode.Disposable { function registerVariableCompletions(pattern: string): vscode.Disposable { return vscode.languages.registerCompletionItemProvider({ language: 'jsonc', pattern }, { - provideCompletionItems(document, position, token) { + provideCompletionItems(document, position, _token) { const location = getLocation(document.getText(), document.offsetAt(position)); if (!location.isAtPropertyKey && location.previousNode && location.previousNode.type === 'string') { const indexOf$ = document.lineAt(position.line).text.indexOf('$'); @@ -153,7 +153,7 @@ function registerExtensionsCompletions(): vscode.Disposable[] { function registerExtensionsCompletionsInExtensionsDocument(): vscode.Disposable { return vscode.languages.registerCompletionItemProvider({ pattern: '**/extensions.json' }, { - provideCompletionItems(document, position, token) { + provideCompletionItems(document, position, _token) { const location = getLocation(document.getText(), document.offsetAt(position)); const range = document.getWordRangeAtPosition(position) || new vscode.Range(position, position); if (location.path[0] === 'recommendations') { @@ -167,7 +167,7 @@ function registerExtensionsCompletionsInExtensionsDocument(): vscode.Disposable function registerExtensionsCompletionsInWorkspaceConfigurationDocument(): vscode.Disposable { return vscode.languages.registerCompletionItemProvider({ pattern: '**/*.code-workspace' }, { - provideCompletionItems(document, position, token) { + provideCompletionItems(document, position, _token) { const location = getLocation(document.getText(), document.offsetAt(position)); const range = document.getWordRangeAtPosition(position) || new vscode.Range(position, position); if (location.path[0] === 'extensions' && location.path[1] === 'recommendations') { @@ -233,15 +233,15 @@ function updateLaunchJsonDecorations(editor: vscode.TextEditor | undefined): voi ranges.push(new vscode.Range(editor.document.positionAt(offset), editor.document.positionAt(offset + length))); } }, - onLiteralValue: (value, offset, length) => { + onLiteralValue: (_value, offset, length) => { if (addPropertyAndValue) { ranges.push(new vscode.Range(editor.document.positionAt(offset), editor.document.positionAt(offset + length))); } }, - onArrayBegin: (offset: number, length: number) => { + onArrayBegin: (_offset: number, _length: number) => { depthInArray++; }, - onArrayEnd: (offset: number, length: number) => { + onArrayEnd: (_offset: number, _length: number) => { depthInArray--; } }); @@ -250,7 +250,7 @@ function updateLaunchJsonDecorations(editor: vscode.TextEditor | undefined): voi } vscode.languages.registerDocumentSymbolProvider({ pattern: '**/launch.json', language: 'jsonc' }, { - provideDocumentSymbols(document: vscode.TextDocument, token: vscode.CancellationToken): vscode.ProviderResult { + provideDocumentSymbols(document: vscode.TextDocument, _token: vscode.CancellationToken): vscode.ProviderResult { const result: vscode.SymbolInformation[] = []; let name: string = ''; let lastProperty = ''; @@ -258,21 +258,21 @@ vscode.languages.registerDocumentSymbolProvider({ pattern: '**/launch.json', lan let depthInObjects = 0; visit(document.getText(), { - onObjectProperty: (property, offset, length) => { + onObjectProperty: (property, _offset, _length) => { lastProperty = property; }, - onLiteralValue: (value: any, offset: number, length: number) => { + onLiteralValue: (value: any, _offset: number, _length: number) => { if (lastProperty === 'name') { name = value; } }, - onObjectBegin: (offset: number, length: number) => { + onObjectBegin: (offset: number, _length: number) => { depthInObjects++; if (depthInObjects === 2) { startOffset = offset; } }, - onObjectEnd: (offset: number, length: number) => { + onObjectEnd: (offset: number, _length: number) => { if (name && depthInObjects === 2) { result.push(new vscode.SymbolInformation(name, vscode.SymbolKind.Object, new vscode.Range(document.positionAt(startOffset), document.positionAt(offset)))); } diff --git a/extensions/configuration-editing/src/settingsDocumentHelper.ts b/extensions/configuration-editing/src/settingsDocumentHelper.ts index 73de7fef8a8..e6b137809ff 100644 --- a/extensions/configuration-editing/src/settingsDocumentHelper.ts +++ b/extensions/configuration-editing/src/settingsDocumentHelper.ts @@ -13,7 +13,7 @@ export class SettingsDocument { constructor(private document: vscode.TextDocument) { } - public provideCompletionItems(position: vscode.Position, token: vscode.CancellationToken): vscode.ProviderResult { + public provideCompletionItems(position: vscode.Position, _token: vscode.CancellationToken): vscode.ProviderResult { const location = getLocation(this.document.getText(), this.document.offsetAt(position)); const range = this.document.getWordRangeAtPosition(position) || new vscode.Range(position, position); @@ -40,7 +40,7 @@ export class SettingsDocument { return this.provideLanguageOverridesCompletionItems(location, position); } - private provideWindowTitleCompletionItems(location: Location, range: vscode.Range): vscode.ProviderResult { + private provideWindowTitleCompletionItems(_location: Location, range: vscode.Range): vscode.ProviderResult { const completions: vscode.CompletionItem[] = []; completions.push(this.newSimpleCompletionItem('${activeEditorShort}', range, localize('activeEditorShort', "the file name (e.g. myFile.txt)"))); @@ -149,7 +149,7 @@ export class SettingsDocument { return Promise.resolve(completions); } - private provideLanguageCompletionItems(location: Location, range: vscode.Range, formatFunc: (string: string) => string = (l) => JSON.stringify(l)): vscode.ProviderResult { + private provideLanguageCompletionItems(_location: Location, range: vscode.Range, formatFunc: (string: string) => string = (l) => JSON.stringify(l)): vscode.ProviderResult { return vscode.languages.getLanguages().then(languages => { const completionItems = []; const configuration = vscode.workspace.getConfiguration(); diff --git a/extensions/configuration-editing/tsconfig.json b/extensions/configuration-editing/tsconfig.json index 84b75434d20..58e3b15279e 100644 --- a/extensions/configuration-editing/tsconfig.json +++ b/extensions/configuration-editing/tsconfig.json @@ -7,7 +7,8 @@ "es2015" ], "strict": true, - "noUnusedLocals": true + "noUnusedLocals": true, + "noUnusedParameters": true }, "include": [ "src/**/*"