maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Always enable dynamic syntax server on TS 4.0+

Browse source 
We are looking for feedback on this new setting. For those on TS 4.0+, it should also be a sensible default
This commit is contained in:
Matt Bierner 2020-06-26 16:18:36 -07:00
parent 9d59cb9813
commit 90de01176e
2 changed files with 6 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
extensions/typescript-language-features/src/tsServer/spawner.ts
View file

@ -93,10 +93,12 @@ export class TypeScriptServerSpawner {
return CompositeServerType.Single; return CompositeServerType.Single;
case SeparateSyntaxServerConfiguration.Enabled: case SeparateSyntaxServerConfiguration.Enabled:
return version.apiVersion?.gte(API.v340) ? CompositeServerType.SeparateSyntax : CompositeServerType.Single; if (version.apiVersion?.gte(API.v340)) {
return version.apiVersion?.gte(API.v400)
case SeparateSyntaxServerConfiguration.Dynamic: ? CompositeServerType.DynamicSeparateSyntax
return version.apiVersion?.gte(API.v400) ? CompositeServerType.DynamicSeparateSyntax : CompositeServerType.Single; : CompositeServerType.SeparateSyntax;
}
return CompositeServerType.Single;
} }
} }

4
extensions/typescript-language-features/src/utils/configuration.ts
View file

@ -49,7 +49,6 @@ export namespace TsServerLogLevel {
export const enum SeparateSyntaxServerConfiguration { export const enum SeparateSyntaxServerConfiguration {
Disabled, Disabled,
Enabled, Enabled,
Dynamic,
} }
export class TypeScriptServiceConfiguration { export class TypeScriptServiceConfiguration {
@ -168,9 +167,6 @@ export class TypeScriptServiceConfiguration {
if (value === true) { if (value === true) {
return SeparateSyntaxServerConfiguration.Enabled; return SeparateSyntaxServerConfiguration.Enabled;
} }
if (value === 'dynamic') {
return SeparateSyntaxServerConfiguration.Dynamic;
}
return SeparateSyntaxServerConfiguration.Disabled; return SeparateSyntaxServerConfiguration.Disabled;
} }