maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Use const enum for types

Browse source
This commit is contained in:
Matt Bierner 2019-11-15 14:05:41 -08:00
parent 46a15a9054
commit 91200b1202
1 changed files with 14 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
extensions/typescript-language-features/src/features/bufferSyncSupport.ts
View file

@ -36,27 +36,31 @@ function mode2ScriptKind(mode: string): 'TS' | 'TSX' | 'JS' | 'JSX' | undefined
return undefined;
}
const enum BufferOperationType { Close, Open, Change }
class CloseOperation {
readonly type = 'close';
readonly type = BufferOperationType.Close;
constructor(
public readonly args: string
) { }
}
class OpenOperation {
readonly type = 'open';
readonly type = BufferOperationType.Open;
constructor(
public readonly args: Proto.OpenRequestArgs
) { }
}
class ChangeOperation {
readonly type = 'change';
readonly type = BufferOperationType.Change;
constructor(
public readonly args: Proto.FileCodeEdits
) { }
}
type BufferOperation = CloseOperation | OpenOperation | ChangeOperation;
/**
* Manages synchronization of buffers with the TS server.
*
@ -64,7 +68,7 @@ class ChangeOperation {
*/
class BufferSynchronizer {
private readonly _pending = new ResourceMap<CloseOperation | OpenOperation | ChangeOperation>();
private readonly _pending = new ResourceMap<BufferOperation>();
constructor(
private readonly client: ITypeScriptServiceClient
@ -137,9 +141,9 @@ class BufferSynchronizer {
const changedFiles: Proto.FileCodeEdits[] = [];
for (const change of this._pending.values) {
switch (change.type) {
case 'change': changedFiles.push(change.args); break;
case 'open': openFiles.push(change.args); break;
case 'close': closedFiles.push(change.args); break;
case BufferOperationType.Change: changedFiles.push(change.args); break;
case BufferOperationType.Open: openFiles.push(change.args); break;
case BufferOperationType.Close: closedFiles.push(change.args); break;
}
}
this.client.execute('updateOpen', { changedFiles, closedFiles, openFiles }, nulToken, { nonRecoverable: true });
@ -151,12 +155,12 @@ class BufferSynchronizer {
return this.client.apiVersion.gte(API.v340);
}
private updatePending(resource: vscode.Uri, op: CloseOperation | OpenOperation | ChangeOperation): void {
private updatePending(resource: vscode.Uri, op: BufferOperation): void {
switch (op.type) {
case 'close':
case BufferOperationType.Close:
const existing = this._pending.get(resource);
switch (existing?.type) {
case 'open':
case BufferOperationType.Open:
this._pending.delete(resource);
return; // Open then close. No need to do anything
}