From 92e20dfe780da35b551161611c3f261d8335b3cd Mon Sep 17 00:00:00 2001 From: Benjamin Pasero Date: Thu, 7 Nov 2019 17:01:42 +0100 Subject: [PATCH] debt - remove typings for sqlite3 (for #83421) --- package.json | 6 +- src/typings/vscode-sqlite3.d.ts | 115 -------------------------------- yarn.lock | 8 +-- 3 files changed, 7 insertions(+), 122 deletions(-) delete mode 100644 src/typings/vscode-sqlite3.d.ts diff --git a/package.json b/package.json index 9595c9037ee..213505617e3 100644 --- a/package.json +++ b/package.json @@ -51,7 +51,7 @@ "vscode-minimist": "^1.2.1", "vscode-proxy-agent": "^0.5.1", "vscode-ripgrep": "^1.5.7", - "vscode-sqlite3": "4.0.8", + "vscode-sqlite3": "4.0.9", "vscode-textmate": "^4.3.0", "xterm": "4.2.0", "xterm-addon-search": "0.3.0", @@ -70,10 +70,10 @@ "@types/node": "^10.12.12", "@types/semver": "^5.5.0", "@types/sinon": "^1.16.36", - "@types/yauzl": "^2.9.1", - "@types/yazl": "^2.4.2", "@types/webpack": "^4.4.10", "@types/winreg": "^1.2.30", + "@types/yauzl": "^2.9.1", + "@types/yazl": "^2.4.2", "ansi-colors": "^3.2.3", "asar": "^0.14.0", "chromium-pickle-js": "^0.2.0", diff --git a/src/typings/vscode-sqlite3.d.ts b/src/typings/vscode-sqlite3.d.ts deleted file mode 100644 index 9a79c4ded1c..00000000000 --- a/src/typings/vscode-sqlite3.d.ts +++ /dev/null @@ -1,115 +0,0 @@ -/*--------------------------------------------------------------------------------------------- - * Copyright (c) Microsoft Corporation. All rights reserved. - * Licensed under the MIT License. See License.txt in the project root for license information. - *--------------------------------------------------------------------------------------------*/ - -// Type definitions for sqlite3 3.1 -// Project: http://github.com/mapbox/node-sqlite3 -// Definitions by: Nick Malaguti -// Sumant Manne -// Behind The Math -// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped - -/// - -declare module 'vscode-sqlite3' { - import events = require("events"); - - export const OPEN_READONLY: number; - export const OPEN_READWRITE: number; - export const OPEN_CREATE: number; - export const OPEN_SHAREDCACHE: number; - export const OPEN_PRIVATECACHE: number; - export const OPEN_URI: number; - - export const cached: { - Database(filename: string, callback?: (this: Database, err: Error | null) => void): Database; - Database(filename: string, mode?: number, callback?: (this: Database, err: Error | null) => void): Database; - }; - - export interface RunResult extends Statement { - lastID: number; - changes: number; - } - - export class Statement extends events.EventEmitter { - bind(callback?: (err: Error | null) => void): this; - bind(...params: any[]): this; - - reset(callback?: (err: null) => void): this; - - finalize(callback?: (err: Error) => void): Database; - - run(callback?: (err: Error | null) => void): this; - run(params: any, callback?: (this: RunResult, err: Error | null) => void): this; - run(...params: any[]): this; - - get(callback?: (err: Error | null, row?: any) => void): this; - get(params: any, callback?: (this: RunResult, err: Error | null, row?: any) => void): this; - get(...params: any[]): this; - - all(callback?: (err: Error | null, rows: any[]) => void): this; - all(params: any, callback?: (this: RunResult, err: Error | null, rows: any[]) => void): this; - all(...params: any[]): this; - - each(callback?: (err: Error | null, row: any) => void, complete?: (err: Error | null, count: number) => void): this; - each(params: any, callback?: (this: RunResult, err: Error | null, row: any) => void, complete?: (err: Error | null, count: number) => void): this; - each(...params: any[]): this; - } - - export class Database extends events.EventEmitter { - constructor(filename: string, callback?: (err: Error | null) => void); - constructor(filename: string, mode?: number, callback?: (err: Error | null) => void); - - close(callback?: (err: Error | null) => void): void; - - run(sql: string, callback?: (this: RunResult, err: Error | null) => void): this; - run(sql: string, params: any, callback?: (this: RunResult, err: Error | null) => void): this; - run(sql: string, ...params: any[]): this; - - get(sql: string, callback?: (this: Statement, err: Error | null, row: any) => void): this; - get(sql: string, params: any, callback?: (this: Statement, err: Error | null, row: any) => void): this; - get(sql: string, ...params: any[]): this; - - all(sql: string, callback?: (this: Statement, err: Error | null, rows: any[]) => void): this; - all(sql: string, params: any, callback?: (this: Statement, err: Error | null, rows: any[]) => void): this; - all(sql: string, ...params: any[]): this; - - each(sql: string, callback?: (this: Statement, err: Error | null, row: any) => void, complete?: (err: Error | null, count: number) => void): this; - each(sql: string, params: any, callback?: (this: Statement, err: Error | null, row: any) => void, complete?: (err: Error | null, count: number) => void): this; - each(sql: string, ...params: any[]): this; - - exec(sql: string, callback?: (this: Statement, err: Error | null) => void): this; - - prepare(sql: string, callback?: (this: Statement, err: Error | null) => void): Statement; - prepare(sql: string, params: any, callback?: (this: Statement, err: Error | null) => void): Statement; - prepare(sql: string, ...params: any[]): Statement; - - serialize(callback?: () => void): void; - parallelize(callback?: () => void): void; - - on(event: "trace", listener: (sql: string) => void): this; - on(event: "profile", listener: (sql: string, time: number) => void): this; - on(event: "error", listener: (err: Error) => void): this; - on(event: "open" | "close", listener: () => void): this; - on(event: string, listener: (...args: any[]) => void): this; - - configure(option: "busyTimeout", value: number): void; - } - - export function verbose(): sqlite3; - - export interface sqlite3 { - OPEN_READONLY: number; - OPEN_READWRITE: number; - OPEN_CREATE: number; - OPEN_SHAREDCACHE: number; - OPEN_PRIVATECACHE: number; - OPEN_URI: number; - cached: typeof cached; - RunResult: RunResult; - Statement: typeof Statement; - Database: typeof Database; - verbose(): this; - } -} \ No newline at end of file diff --git a/yarn.lock b/yarn.lock index c965f033387..703d5391bae 100644 --- a/yarn.lock +++ b/yarn.lock @@ -8977,10 +8977,10 @@ vscode-ripgrep@^1.5.7: resolved "https://registry.yarnpkg.com/vscode-ripgrep/-/vscode-ripgrep-1.5.7.tgz#acb6b548af488a4bca5d0f1bb5faf761343289ce" integrity sha512-/Vsz/+k8kTvui0q3O74pif9FK0nKopgFTiGNVvxicZANxtSA8J8gUE9GQ/4dpi7D/2yI/YVORszwVskFbz46hQ== -vscode-sqlite3@4.0.8: - version "4.0.8" - resolved "https://registry.yarnpkg.com/vscode-sqlite3/-/vscode-sqlite3-4.0.8.tgz#1eba415b996d2661628d80d4a191a20767713829" - integrity sha512-FsFtYSHmy0mYjtt9ibFKsJqbRzqaltDKZ5SLdpykjvORugFMr0HfGunkh+qGaz9CvAiqjM2KVO91NE9KdyTWKQ== +vscode-sqlite3@4.0.9: + version "4.0.9" + resolved "https://registry.yarnpkg.com/vscode-sqlite3/-/vscode-sqlite3-4.0.9.tgz#cad04964aff1e39121dd8c7cdb87c64a71bad9ce" + integrity sha512-g/xnAn4sgkVO+px/DfC7kpmCQ666W124tfMSVpbnQXsjMHlLhi4Urz4wPhS9YEFPz1Orl6h6MUF6wptzI6QFdg== dependencies: nan "^2.14.0"