add vscode-dts-compile-check to ensure that vscode.d.ts is self-contained, esp that it doesn't depend on vscode.proposed.d.ts, and that uses es5 only

.github/workflows/ci.yml

@@ -253,6 +253,9 @@ jobs:
       - name: Run Monaco Editor Checks
         run: yarn monaco-compile-check
 
+      - name: Run vscode-dts Compile Checks
+        run: yarn vscode-dts-compile-check
+
       - name: Run Trusted Types Checks
         run: yarn tsec-compile-check
 

package.json

@@ -40,6 +40,7 @@
     "download-builtin-extensions-cg": "node build/lib/builtInExtensionsCG.js",
     "monaco-compile-check": "tsc -p src/tsconfig.monaco.json --noEmit",
     "tsec-compile-check": "node node_modules/tsec/bin/tsec -p src/tsconfig.tsec.json",
+    "vscode-dts-compile-check": "node node_modules/tsec/bin/tsec -p src/tsconfig.vscode-dts.json",
     "valid-layers-check": "node build/lib/layersChecker.js",
     "update-distro": "node build/npm/update-distro.js",
     "web": "node resources/web/code-web.js",

src/tsconfig.vscode-dts.json

@@ -0,0 +1,22 @@
+{
+	"compilerOptions": {
+		"noEmit": true,
+		"module": "None",
+		"experimentalDecorators": false,
+		"noImplicitReturns": true,
+		"noImplicitOverride": true,
+		"noUnusedLocals": true,
+		"allowUnreachableCode": false,
+		"strict": true,
+		"exactOptionalPropertyTypes": false,
+		"useUnknownInCatchVariables": false,
+		"forceConsistentCasingInFileNames": true,
+		"types": [],
+		"lib": [
+			"es5",
+		],
+	},
+	"include": [
+		"vs/vscode.d.ts"
+	]
+}