maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

fixes #107903

Browse source
This commit is contained in:
João Moreno 2020-10-05 17:56:28 +02:00
parent f76edc7e68
commit 993c987e93
3 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/vs/workbench/contrib/extensions/browser/extensionsActions.ts
View file

@ -731,6 +731,7 @@ export function getContextMenuActions(menuService: IMenuService, contextKeyServi
return instantiationService.createInstance(MenuItemExtensionAction, action);
})));
menu.dispose();
scopedContextKeyService.dispose();
return groups;
}

1
src/vs/workbench/contrib/timeline/browser/timelinePane.ts
View file

@ -1236,6 +1236,7 @@ class TimelinePaneCommands extends Disposable {
createAndFillInContextMenuActions(menu, { shouldForwardArgs: true }, result, this.contextMenuService, g => /^inline/.test(g));
menu.dispose();
scoped.dispose();
return result;
}

5
src/vs/workbench/contrib/views/browser/treeView.ts
View file

@ -1027,9 +1027,8 @@ class TreeMenus extends Disposable implements IDisposable {
createAndFillInContextMenuActions(menu, { shouldForwardArgs: true }, result, this.contextMenuService, g => /^inline/.test(g));
menu.dispose();
// When called without a parameter, updateParent will dispose the parent change listener.
// We cannot call dispose on the contextKeyService because it will break submenus.
contextKeyService.updateParent();
contextKeyService.dispose();
return result;
}
}