maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

file working copy - update todos

Browse source
This commit is contained in:
Benjamin Pasero 2021-03-18 16:13:22 +01:00
parent 6bea69b5e2
commit 9cd4712b35
No known key found for this signature in database
GPG key ID: E6380CC4C8219E65
2 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/bootstrap-node.js vendored
View file

@ -10,7 +10,7 @@
// - Windows: call `process.chdir()` to always set application folder as cwd
// - Posix: allow to change the current working dir via `VSCODE_CWD` if defined
// - all OS: store the `process.cwd()` inside `VSCODE_CWD` for consistent lookups
// // TODO@bpasero revisit if chdir() on Windows is needed in the future still
// TODO@bpasero revisit if chdir() on Windows is needed in the future still
function setupCurrentWorkingDirectory() {
const path = require('path');

8
src/vs/workbench/services/workingCopy/common/fileWorkingCopy.ts
View file

@ -66,8 +66,6 @@ export interface IFileWorkingCopyModel {
* Snapshots the model's current content for writing. This must include
* any changes that were made to the model that are in memory.
*
* TODO@bpasero could this method return sync and not promise?
*
* @param token support for cancellation
*/
snapshot(token: CancellationToken): Promise<VSBufferReadableStream>;
@ -89,7 +87,7 @@ export interface IFileWorkingCopyModel {
* case of undo-redo.
*
* TODO@bpasero should find a better name here maybe together
* with the pushStackElement concept since this is around
* with the `pushStackElement` concept since this is around
* undo/redo?
*/
getAlternativeVersionId(): number;
@ -102,7 +100,9 @@ export interface IFileWorkingCopyModel {
* save is triggered so that the user can always undo back
* to the state before saving.
*
* TODO@bpasero rename to beforeSave()?
* TODO@bpasero should find a better name here maybe together
* with the `getAlternativeVersionId` concept since this is around
* undo/redo?
*/
pushStackElement(): void;
}