maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

debt - use a native private property in ExtHostQuickInput

Browse source
This commit is contained in:
Johannes Rieken 2021-02-03 09:44:52 +01:00
parent c399d039a7
commit a01d16e77e
2 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
extensions/vscode-api-tests/src/singlefolder-tests/rpc.test.ts
View file

@ -38,14 +38,12 @@ suite('vscode', function () {
});
test('no rpc, createQuickPick(...)', function () {
this.skip();
const item = vscode.window.createQuickPick();
dispo.push(item);
assertNoRpcFromEntry([item, 'QuickPick']);
});
test('no rpc, createInputBox(...)', function () {
this.skip();
const item = vscode.window.createInputBox();
dispo.push(item);
assertNoRpcFromEntry([item, 'InputBox']);

8
src/vs/workbench/api/common/extHostQuickOpen.ts
View file

@ -233,6 +233,7 @@ class ExtHostQuickInput implements QuickInput {
private static _nextId = 1;
_id = ExtHostQuickPick._nextId++;
#proxy: MainThreadQuickOpenShape;
private _title: string | undefined;
private _steps: number | undefined;
private _totalSteps: number | undefined;
@ -260,7 +261,8 @@ class ExtHostQuickInput implements QuickInput {
this._onDidChangeValueEmitter
];
constructor(protected _proxy: MainThreadQuickOpenShape, protected _extensionId: ExtensionIdentifier, private _onDidDispose: () => void) {
constructor(proxy: MainThreadQuickOpenShape, protected _extensionId: ExtensionIdentifier, private _onDidDispose: () => void) {
this.#proxy = proxy;
}
get title() {
@ -409,7 +411,7 @@ class ExtHostQuickInput implements QuickInput {
this._updateTimeout = undefined;
}
this._onDidDispose();
this._proxy.$dispose(this._id);
this.#proxy.$dispose(this._id);
}
protected update(properties: Record<string, any>): void {
@ -437,7 +439,7 @@ class ExtHostQuickInput implements QuickInput {
}
private dispatchUpdate() {
this._proxy.$createOrUpdate(this._pendingUpdate);
this.#proxy.$createOrUpdate(this._pendingUpdate);
this._pendingUpdate = { id: this._id };
}
}