maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Remove onCommand from markdown preview

Browse source
This commit is contained in:
Matt Bierner 2018-09-21 13:36:37 -07:00
parent 388a62fe12
commit a101ececf4
7 changed files with 11 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
extensions/markdown-language-features/media/index.js
View file

File diff suppressed because one or more lines are too long

4
extensions/markdown-language-features/media/pre.js
View file

File diff suppressed because one or more lines are too long

2
extensions/markdown-language-features/preview-src/csp.ts
View file

@ -57,7 +57,7 @@ export class CspAlerter {
notification.setAttribute('role', 'button');
notification.setAttribute('aria-label', strings.cspAlertMessageLabel);
notification.onclick = () => {
this.messaging!.postMessage('markdown.showPreviewSecuritySelector', [settings.source]);
this.messaging!.postMessage('showPreviewSecuritySelector', { source: settings.source });
};
document.body.appendChild(notification);
}

2
extensions/markdown-language-features/preview-src/index.ts
View file

@ -133,7 +133,7 @@ document.addEventListener('click', event => {
}
if (node.href.startsWith('file://') || node.href.startsWith('vscode-resource:')) {
const [path, fragment] = node.href.replace(/^(file:\/\/|vscode-resource:)/i, '').split('#');
messaging.postCommand('_markdown.openDocumentLink', [{ path, fragment }]);
messaging.postMessage('clickLink', { path, fragment });
event.preventDefault();
event.stopPropagation();
break;

8
extensions/markdown-language-features/preview-src/messaging.ts
View file

@ -10,11 +10,6 @@ export interface MessagePoster {
* Post a message to the markdown extension
*/
postMessage(type: string, body: object): void;
/**
* Post a command to be executed to the markdown extension
*/
postCommand(command: string, args: any[]): void;
}
export const createPosterForVsCode = (vscode: any) => {
@ -26,9 +21,6 @@ export const createPosterForVsCode = (vscode: any) => {
body
});
}
postCommand(command: string, args: any[]) {
this.postMessage('command', { command, args });
}
};
};

2
extensions/markdown-language-features/src/features/documentLinkProvider.ts
View file

@ -20,7 +20,7 @@ function normalizeLink(
// Assume it must be an relative or absolute file path
// Use a fake scheme to avoid parse warnings
const tempUri = vscode.Uri.parse(`fake-scheme:${link}`);
const tempUri = vscode.Uri.parse(`vscode-resource:${link}`);
let resourcePath = tempUri.path;
if (!tempUri.path) {

8
extensions/markdown-language-features/src/features/preview.ts
View file

@ -128,10 +128,6 @@ export class MarkdownPreview {
this.onCacheImageSizes(e.body);
break;
case 'command':
vscode.commands.executeCommand(e.body.command, ...e.body.args);
break;
case 'revealLine':
this.onDidScrollPreview(e.body.line);
break;
@ -140,6 +136,10 @@ export class MarkdownPreview {
this.onDidClickPreview(e.body.line);
break;
case 'clickLink':
vscode.commands.executeCommand('_markdown.openDocumentLink', e.body);
break;
case 'showPreviewSecuritySelector':
vscode.commands.executeCommand('markdown.showPreviewSecuritySelector', e.body.source);
break;