Don't show icon until its resolved

This commit is contained in:
Daniel Imms 2021-05-24 11:53:28 -07:00
parent f7f6956554
commit a31d9ca699
2 changed files with 1 additions and 2 deletions

View file

@ -1874,7 +1874,6 @@ export class TerminalInstance extends Disposable implements ITerminalInstance {
class TerminalInstanceDropAndDropController extends Disposable implements IDragAndDropObserverCallbacks {
private _dropOverlay?: HTMLElement;
private readonly _onDropFile = new Emitter<string>();
get onDropFile(): Event<string> { return this._onDropFile.event; }
private readonly _onDropTerminal = new Emitter<IRequestAddInstanceToGroupEvent>();

View file

@ -273,10 +273,10 @@ class TerminalTabsRenderer implements IListRenderer<ITerminalInstance, ITerminal
}
} else {
this.fillActionBar(instance, template);
label = `${prefix}$(${iconId})`;
// Only add the title if the icon is set, this prevents the title jumping around for
// example when launching with a ShellLaunchConfig.name and no icon
if (instance.icon) {
label = `${prefix}$(${iconId})`;
label += ` ${instance.title}`;
}
}