From a455381dd18af6eb7e35284fa8324728e520accb Mon Sep 17 00:00:00 2001 From: Benjamin Pasero Date: Mon, 4 Feb 2019 09:55:28 +0100 Subject: [PATCH] debt - disallow cross-part dependencies for files part --- .../test/browser/fileEditorInput.test.ts | 1 + tslint.json | 48 +++++++++++++++++++ 2 files changed, 49 insertions(+) diff --git a/src/vs/workbench/parts/files/test/browser/fileEditorInput.test.ts b/src/vs/workbench/parts/files/test/browser/fileEditorInput.test.ts index 54c12010023..2e5676deab9 100644 --- a/src/vs/workbench/parts/files/test/browser/fileEditorInput.test.ts +++ b/src/vs/workbench/parts/files/test/browser/fileEditorInput.test.ts @@ -2,6 +2,7 @@ * Copyright (c) Microsoft Corporation. All rights reserved. * Licensed under the MIT License. See License.txt in the project root for license information. *--------------------------------------------------------------------------------------------*/ + import * as assert from 'assert'; import { URI } from 'vs/base/common/uri'; import { join } from 'vs/base/common/paths'; diff --git a/tslint.json b/tslint.json index 67a640687c9..3d7876e972d 100644 --- a/tslint.json +++ b/tslint.json @@ -457,6 +457,54 @@ "*" // node modules ] }, + { + "target": "**/vs/workbench/parts/files/common/**", + "restrictions": [ + "vs/nls", + "**/vs/base/common/**", + "**/vs/base/parts/*/common/**", + "**/vs/platform/*/common/**", + "**/vs/editor/common/**", + "**/vs/editor/contrib/*/common/**", + "**/vs/workbench/common/**", + "**/vs/workbench/services/*/common/**", + "**/vs/workbench/parts/files/common/**", + "assert" + ] + }, + { + "target": "**/vs/workbench/parts/files/browser/**", + "restrictions": [ + "vs/nls", + "vs/css!./**/*", + "**/vs/base/{common,browser}/**", + "**/vs/base/parts/*/{common,browser}/**", + "**/vs/platform/*/{common,browser}/**", + "**/vs/editor/{common,browser}/**", + "**/vs/editor/contrib/**", // editor/contrib is equivalent to /browser/ by convention + "**/vs/workbench/{common,browser}/**", + "**/vs/workbench/services/*/{common,browser}/**", + "**/vs/workbench/parts/files/{common,browser}/**", + "assert" + ] + }, + { + "target": "**/vs/workbench/parts/files/electron-browser/**", + "restrictions": [ + "vs/nls", + "vs/css!./**/*", + "**/vs/base/{common,browser,node,electron-browser}/**", + "**/vs/base/parts/*/{common,browser,node,electron-browser}/**", + "**/vs/platform/node/**", + "**/vs/platform/*/{common,browser,node,electron-browser}/**", + "**/vs/editor/{common,browser,node,electron-browser}/**", + "**/vs/editor/contrib/**", // editor/contrib is equivalent to /browser/ by convention + "**/vs/workbench/{common,browser,node,electron-browser,api}/**", + "**/vs/workbench/services/*/{common,browser,node,electron-browser}/**", + "**/vs/workbench/parts/files/{common,browser,node,electron-browser}/**", + "*" // node modules + ] + }, { "target": "**/vs/code/node/**", "restrictions": [