From a5cc64cd6ace486d6c6e1ac85c68452d392b7652 Mon Sep 17 00:00:00 2001 From: rebornix Date: Tue, 10 Aug 2021 13:41:11 -0700 Subject: [PATCH] tooltip for double click. --- .../contrib/notebook/browser/view/renderers/cellRenderer.ts | 6 ++---- .../contrib/notebook/browser/view/renderers/codeCell.ts | 5 ++--- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/src/vs/workbench/contrib/notebook/browser/view/renderers/cellRenderer.ts b/src/vs/workbench/contrib/notebook/browser/view/renderers/cellRenderer.ts index 257854091bd..d9acabd1a0c 100644 --- a/src/vs/workbench/contrib/notebook/browser/view/renderers/cellRenderer.ts +++ b/src/vs/workbench/contrib/notebook/browser/view/renderers/cellRenderer.ts @@ -716,13 +716,11 @@ export class CodeCellRenderer extends AbstractCellRenderer implements IListRende expandIcon.classList.add(...CSSIcon.asClassNameArray(Codicon.more)); const keybinding = this.keybindingService.lookupKeybinding(EXPAND_CELL_OUTPUT_COMMAND_ID); - let title = localize('cellExpandOutputButtonLabel', "Expand Cell Output"); if (keybinding) { - title += ` (${keybinding.getLabel()})`; + placeholder.title = localize('cellExpandOutputButtonLabelWithDoubleClick', "Double click to expand cell output ({0})", keybinding.getLabel()); + cellOutputCollapseContainer.title = localize('cellExpandOutputButtonLabel', "Expand Cell Output (${0})", keybinding.getLabel()); } - cellOutputCollapseContainer.title = title; - DOM.hide(cellOutputCollapseContainer); const expand = () => { diff --git a/src/vs/workbench/contrib/notebook/browser/view/renderers/codeCell.ts b/src/vs/workbench/contrib/notebook/browser/view/renderers/codeCell.ts index 483e20a90c2..dac77c015b2 100644 --- a/src/vs/workbench/contrib/notebook/browser/view/renderers/codeCell.ts +++ b/src/vs/workbench/contrib/notebook/browser/view/renderers/codeCell.ts @@ -278,12 +278,11 @@ export class CodeCell extends Disposable { this.templateData.cellInputCollapsedContainer.appendChild(element); const expandIcon = DOM.$('span.expandInputIcon'); const keybinding = this.keybindingService.lookupKeybinding(EXPAND_CELL_INPUT_COMMAND_ID); - let title = localize('cellExpandInputButtonLabel', "Expand Cell Input"); if (keybinding) { - title += ` (${keybinding.getLabel()})`; + element.title = localize('cellExpandInputButtonLabelWithDoubleClick', "Double click to expand cell input ({0})", keybinding.getLabel()); + expandIcon.title = localize('cellExpandInputButtonLabel', "Expand Cell Input ({0})", keybinding.getLabel()); } - expandIcon.title = title; expandIcon.classList.add(...CSSIcon.asClassNameArray(Codicon.more)); element.appendChild(expandIcon);