From a816fcfb6b5af4f14a05eaa5e6d798ec1f9cb4b7 Mon Sep 17 00:00:00 2001
From: Matt Bierner <matb@microsoft.com>
Date: Thu, 1 Apr 2021 12:13:42 -0700
Subject: [PATCH] Hide outputs with visibility instead of display

This improves perceived performance when outputs are hidden by folding
---
 .../browser/view/renderers/webviewPreloads.ts       | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/src/vs/workbench/contrib/notebook/browser/view/renderers/webviewPreloads.ts b/src/vs/workbench/contrib/notebook/browser/view/renderers/webviewPreloads.ts
index 1628947c290..50489962e84 100644
--- a/src/vs/workbench/contrib/notebook/browser/view/renderers/webviewPreloads.ts
+++ b/src/vs/workbench/contrib/notebook/browser/view/renderers/webviewPreloads.ts
@@ -679,7 +679,7 @@ function webviewPreloads() {
 					}
 
 					// don't hide until after this step so that the height is right
-					cellOutputContainer.style.display = data.initiallyHidden ? 'none' : 'block';
+					cellOutputContainer.style.visibility = data.initiallyHidden ? 'hidden' : 'visible';
 				});
 				break;
 			case 'view-scroll':
@@ -692,7 +692,7 @@ function webviewPreloads() {
 						if (widget) {
 							widget.style.top = request.top + 'px';
 							if (request.forceDisplay) {
-								widget.parentElement!.style.display = 'block';
+								widget.parentElement!.style.visibility = 'visible';
 							}
 						}
 					}
@@ -702,11 +702,6 @@ function webviewPreloads() {
 						if (widget) {
 							widget.style.top = `${cell.top}px`;
 						}
-
-						const markdownPreview = document.getElementById(`${cell.id}`);
-						if (markdownPreview) {
-							markdownPreview.style.display = 'block';
-						}
 					}
 
 					break;
@@ -737,7 +732,7 @@ function webviewPreloads() {
 				enqueueOutputAction(event.data, ({ outputId }) => {
 					const container = document.getElementById(outputId)?.parentElement;
 					if (container) {
-						container.style.display = 'none';
+						container.style.visibility = 'hidden';
 					}
 				});
 				break;
@@ -745,7 +740,7 @@ function webviewPreloads() {
 				enqueueOutputAction(event.data, ({ outputId, top }) => {
 					const output = document.getElementById(outputId);
 					if (output) {
-						output.parentElement!.style.display = 'block';
+						output.parentElement!.style.visibility = 'visible';
 						output.style.top = top + 'px';
 
 						dimensionUpdater.update(outputId, {