maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

untitleHint: use expereiment service

Browse source
This commit is contained in:
isidor 2021-03-09 16:31:58 +01:00
parent 90efd0a81a
commit b02e102f48
No known key found for this signature in database
GPG key ID: F9280366A8370105
1 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/vs/workbench/browser/parts/editor/untitledHint.ts
View file

@ -18,6 +18,7 @@ import { Schemas } from 'vs/base/common/network';
import { IConfigurationService } from 'vs/platform/configuration/common/configuration';
import { IKeybindingService } from 'vs/platform/keybinding/common/keybinding';
import { FloatingClickWidget } from 'vs/workbench/browser/codeeditor';
import { ITASExperimentService } from 'vs/workbench/services/experiment/common/experimentService';
const $ = dom.$;
const untitledHintSetting = 'workbench.editor.untitled.hint';
@ -34,7 +35,8 @@ export class UntitledHintContribution implements IEditorContribution {
@ICommandService private readonly commandService: ICommandService,
@IConfigurationService private readonly configurationService: IConfigurationService,
@IKeybindingService private readonly keybindingService: IKeybindingService,
@IThemeService private readonly themeService: IThemeService
@IThemeService private readonly themeService: IThemeService,
@ITASExperimentService private readonly experimentService: ITASExperimentService
) {
this.toDispose = [];
this.toDispose.push(this.editor.onDidChangeModel(() => this.update()));
@ -47,10 +49,12 @@ export class UntitledHintContribution implements IEditorContribution {
this.update();
}
private update(): void {
private async update(): Promise<void> {
this.untitledHintContentWidget?.dispose();
this.button?.dispose();
const untitledHintMode = this.configurationService.getValue(untitledHintSetting);
const experimentService = await this.experimentService.getTreatment<'text' | 'button'>('untitledhint');
const configValue = this.configurationService.getValue<'text' | 'button' | 'hidden'>(untitledHintSetting);
const untitledHintMode = configValue === 'hidden' ? configValue : (experimentService || configValue);
const model = this.editor.getModel();
if (model && model.uri.scheme === Schemas.untitled && model.getModeId() === PLAINTEXT_MODE_ID) {