maxmustermann/vscode
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Revert "Dispose of TerminalInstance._onExit only on instance dispose"

Browse source 
This reverts commit 1c1d04bc6f.
This commit is contained in:
Daniel Imms 2021-08-11 04:49:20 -07:00
parent a6cf57db06
commit b21cedc9e8
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/vs/workbench/contrib/terminal/browser/terminalInstance.ts
View file

@ -209,8 +209,11 @@ export class TerminalInstance extends Disposable implements ITerminalInstance {
get icon(): TerminalIcon | undefined { return this._getIcon(); }
get color(): string | undefined { return this._getColor(); }
private readonly _onExit = this._register(new Emitter<number | undefined>());
// The onExit event is special in that it fires and is disposed after the terminal instance
// itself is disposed
private readonly _onExit = new Emitter<number | undefined>();
readonly onExit = this._onExit.event;
private readonly _onDisposed = this._register(new Emitter<ITerminalInstance>());
readonly onDisposed = this._onDisposed.event;
private readonly _onProcessIdReady = this._register(new Emitter<ITerminalInstance>());
@ -1330,6 +1333,7 @@ export class TerminalInstance extends Disposable implements ITerminalInstance {
}
this._onExit.fire(this._exitCode);
this._onExit.dispose();
}
/**